Skip to content

[product] fix dev mode debug text color contrast #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yonava merged 4 commits into from
Oct 18, 2025
Merged

[product] fix dev mode debug text color contrast #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89ab0fa
change color to black
teykamp Sep 8, 2025
65f527c
fix formatting
teykamp Sep 8, 2025
9d1a15c
move to gText
teykamp Oct 18, 2025
abde321
Merge branch 'main' into te/update-debug-mode-text-color
Yonava Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/products/src/shared/ui/general/dev/BenchmarkingMetrics.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
<script setup lang="ts">
import { useFPS } from "@magic/utils/fps";
import { useFPS } from "@magic/utils/fps";
import GText from "../../graph-core/GText.vue";

const { fps, slowFrameCount, slowFrameRatio } = useFPS();
const { fps, slowFrameCount, slowFrameRatio } = useFPS();
</script>

<template>
Copy link
Owner

@Yonava Yonava Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap in GText

<div class="text-white text-end">
<GText class="text-end">
<div>FPS: {{ fps }}</div>
<div>Slow Frame Count: {{ slowFrameCount }}</div>
<div>Slow Frame Ratio: {{ slowFrameRatio.toFixed(2) }}</div>
</div>
</GText>
</template>
34 changes: 18 additions & 16 deletions packages/products/src/shared/ui/general/dev/GraphAtMousePositionData.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,28 @@
<script setup lang="ts">
import { nonNullGraph as graph } from "../../../../shared/globalGraph";
import { nonNullGraph as graph } from "../../../../shared/globalGraph";

import { computed } from "vue";

const coords = computed(() => {
const {
coords: { x, y },
} = graph.value.graphAtMousePosition.value;
return { x: Math.round(x), y: Math.round(y) };
});
import { computed } from "vue";
import GText from "../../graph-core/GText.vue";

const hoveredItems = computed(() => {
const { items } = graph.value.graphAtMousePosition.value;
return items.map(
(item) => `${item.graphType} - ${item.shape.name} (${item.id})`
);
});
const coords = computed(() => {
const {
coords: { x, y },
} = graph.value.graphAtMousePosition.value;
return { x: Math.round(x), y: Math.round(y) };
});

const hoveredItems = computed(() => {
const { items } = graph.value.graphAtMousePosition.value;
return items.map(
(item) => `${item.graphType} - ${item.shape.name} (${item.id})`
);
});
</script>

<template>
<div class="text-white text-end">
<GText class="text-end">
<div>Cursor At: (X = {{ coords.x }}, Y = {{ coords.y }})</div>
<div>Items Hovered: {{ hoveredItems }}</div>
</div>
</GText>
</template>
Loading