-
Notifications
You must be signed in to change notification settings - Fork 2
Incorporate Findings from Review #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BirgitBoss
wants to merge
113
commits into
smt-xg/BatteryPass_Working
Choose a base branch
from
BiBo/incorporateFindings_#1
base: smt-xg/BatteryPass_Working
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
113 commits
Select commit
Hold shift + click to select a range
de17510
GeneralInforamtion:
BirgitBoss b3c60de
PACT Carbon Footpring:
BirgitBoss 3209795
PCF:
BirgitBoss d1dc0af
fix Characteristics for MultiLanguageProperties
BirgitBoss e8f58b9
update preferrred name German conformant to ECLASS
BirgitBoss f1a97b8
Generic Technical Data:
BirgitBoss d8d9bb5
ContactInformation: added exampleValues + formatting
BirgitBoss f34bbf5
remove example value for anyURI: leads to error in validation
BirgitBoss 0509203
fix datatype of dateOfManufacturer to xsd:date
BirgitBoss 17bb804
newly generated files for changed Aspect Models
BirgitBoss 97055c7
TechnicalDataBattery: fix numberOfFullCycles - must be expectedNumber…
BirgitBoss b97e53a
add example values
BirgitBoss 13cc1e0
newly generated files
BirgitBoss c7d4eeb
example values added
BirgitBoss a33add7
ContactInformation: some additional example values + formatting
BirgitBoss 387288f
newly generated files
BirgitBoss dce6727
minor fixes
tobzahn 708dc32
README: new CLI for validation
BirgitBoss ecfa8ff
circularity: newly generated files
BirgitBoss ace85d6
PCF: removed redundant PcfCalculationSet
BirgitBoss 1236b57
Aspect renamed from CarbonFootprint to CarbonFootprintBattery
BirgitBoss 48b90f3
Merge pull request #37 from tobzahn/batterypass
BirgitBoss 3b4de18
Technical Data: fix type
BirgitBoss b75624d
PCF: Type + formatting
BirgitBoss a1ddbf8
newly generated files
BirgitBoss c9deaee
Merge branch 'BiBo/incorporateFindings_#1' of https://github.com/admi…
BirgitBoss ba5da87
Merge branch 'BiBo/incorporateFindings_#1' of https://github.com/admi…
BirgitBoss 305dba3
Technical Data Bugfix Resistance: incorrect payload names, inconsiste…
BirgitBoss 84d4bca
PCF: upate README: payload names now considered
BirgitBoss 3536730
Technical Data: fix typo in payload name RatioNorminalBatteryPowerAnd…
BirgitBoss 4de266c
use bp: <urn:samm:io.BatteryPass.Performance:1.2.1#> instead of bp:…
BirgitBoss 0541b21
CarbonFootprint: remove redundant property definition (productOrSecto…
BirgitBoss aa5e038
formatting only
BirgitBoss cc17b80
Technical Data: use bp: <urn:samm:io.BatteryPass.Performance:1.2.1#> …
BirgitBoss 34fff2f
PactCarbonFootprint: remove redundant samm:see information
BirgitBoss 919f597
CarbonFootpring: add exampleValues for samm-C:Timestamp
BirgitBoss 4e2a43c
formatting
BirgitBoss 3e00b16
formatting
BirgitBoss ab7dc56
newly generated files
BirgitBoss 417514a
CarbonFootpring: remove redundant Charateristic :ProductOrSectorSpeci…
BirgitBoss 2c5e4ae
CarbonFootpring: remove redundant and unused Characteristic :LifeCylc…
BirgitBoss 29973af
TechnicalData: fix syntax errors
BirgitBoss aeacf7c
newly generated files
BirgitBoss 7bb396c
Handover Description: add namespace description as .tll file
BirgitBoss fa43ee2
HandoverDocumentation: updating README for Namespace.ttl
BirgitBoss 9fe7b5b
CarbonFootprint: remove redundant Characteristics
BirgitBoss a29e368
ContactInformation: fix example values + use values from samm:Values …
BirgitBoss 2849bd7
ContactInformation: enumerations and enumeration values added
BirgitBoss 57cf3da
CarbonFootprintBattey: use io.catenax.pcf:8.00 instead of 7.0.0
BirgitBoss a09684c
TechnicalData Battery: remove properties not used
BirgitBoss ad53348
PCF PACT: remove file containing redudant elements only
BirgitBoss 6826dc0
CarbonFooprint and CarbonFootpringPACT: use io.catenax.pcf:8.0.0
BirgitBoss 961ce44
newly generated files
BirgitBoss 52a8612
shared Markings: add enumeration and value definitions
BirgitBoss 980e191
Handover Docu: fix typo in payload name
BirgitBoss 35542ef
Handover Docu: fix typo in payload name
BirgitBoss 8e072dc
Handover Docu: document deviation and issue number for Languages
BirgitBoss 7103ff7
Handover Docu: fix cardainlity for documentVersions: it is mandatory
BirgitBoss 6dd3612
remove generated .aasx, aas.xml and aas.json files for SMT with aasx …
BirgitBoss e773e82
improved documentation of namespace handover documentation
BirgitBoss def2fe7
formatting only
BirgitBoss eda6acc
formatting only
BirgitBoss 985dca3
add namespace.ttl also to Circularity, MaterialComposition and Produc…
BirgitBoss 63969c2
correction of READMEs
BirgitBoss e96da1d
characteristics: Blob, RelationshipElement, split contentType because…
BirgitBoss 30afaf3
remove contentType that is reused with Blob
BirgitBoss 6655784
update Test Aspect for Blob and RelationshipElement
BirgitBoss 41587da
handoverDocu: remove aas files from generated files
BirgitBoss afbd25b
Nameplate: remove aas files from generated files
BirgitBoss 9718d93
technicalData: remove aas files from generated files
BirgitBoss 1d71ee3
contactInformation: remove aas files from generated files
BirgitBoss 0ef8c68
CarbonFootprint: remove aas files from generated files
BirgitBoss 4dfeb18
add missing properties for Technical Data: furtherInformation and gen…
BirgitBoss e36a6cb
ProductConditionBatteryStationaryLMT: remove aas files from generated…
BirgitBoss f512e06
MaterialCompositionBattery: remove aas files from generated files
BirgitBoss c5f5ea2
CircularityBattery: remove aas files from generated files
BirgitBoss 6a25d47
ProductConditionBattery: remove aas files from generated files
BirgitBoss 71cc309
add newly generated .json and .html files
BirgitBoss f1ad783
Merge pull request #41 from admin-shell-io/BiBo/incorporateFindings_#2
BirgitBoss 4b43cfb
licensing was corrected in io.battery: information updated + fix of s…
BirgitBoss c6ee9e5
Merge pull request #42 from admin-shell-io/BiBo/incorporateFindings_#3
BirgitBoss 37829ff
correct license information in Readme
BirgitBoss 12258c8
correct DIN SPEC 99100 to DIN DKE SPEC 99100
BirgitBoss 9f67f7e
update Readme
BirgitBoss 5d3f63c
correct license info
BirgitBoss eef86ea
update Readme
BirgitBoss d0d831a
improve Readme
BirgitBoss d716bc2
PCF: modelled enum for LifeCyclePhases (before string)
BirgitBoss aca6ca2
fix syntax
BirgitBoss 98f3dc5
added: optional documentedEntities
BirgitBoss ce67495
SML Languages is Language conformant to Spec. Readme updated to expla…
BirgitBoss 37c3067
PCF: fix typo o pcf2CoEq
BirgitBoss b34804b
correct and add missing semanticIds for GoodsHandoverAddress
BirgitBoss 0d8f397
PCF: fixed language codes
BirgitBoss 2e67dd3
ProductOrSectorSpecificCarbonFootprint/PcfInformation is mandatory: f…
BirgitBoss d04731a
newly generated html files for CarbonFootprint and CarbonFootprintBat…
BirgitBoss 96841d3
bugfix HandoverDocumentation
BirgitBoss 3072cab
newly generated files
BirgitBoss d1ee705
Merge pull request #43 from admin-shell-io/BiBo/incorporateFindings_#4
BirgitBoss bdd5151
bugfix ContactInformation typo in payload
BirgitBoss 5f103cf
PCF preferrred name improved Plural
BirgitBoss 5a63a47
PCF Plural description
BirgitBoss 2fcb81c
bugfix description special char
BirgitBoss 80acd8c
Circularity: add preferred name
BirgitBoss 45ec083
technical Properties: change of BatteryPass name
BirgitBoss 21bf369
editorial
BirgitBoss 039e064
Contact Information: renaming of Charactersitics + adding preferred n…
BirgitBoss 43ae58c
Circularity and Documentation: decision JWG to only add a set of Docu…
BirgitBoss 1bcf804
generated files
BirgitBoss ef11f99
Technical Data: renamed NumberOfChargeDischargeCycles to ExpectedNumb…
BirgitBoss 54e12ec
Technical Data generic 2.0.0
BirgitBoss 555e716
Battery Technical Data: use Technical Data generic 2.0.0
BirgitBoss b2e8148
Merge pull request #50 from admin-shell-io/BiBo/incoporateFindings_#5
BirgitBoss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-4 Bytes
(100%)
io.admin-shell.idta.batterypass.carbon_footprint/1.0.0/gen/CarbonFootprintBattery.aasx
Binary file not shown.
92 changes: 90 additions & 2 deletions
92
io.admin-shell.idta.batterypass.carbon_footprint/1.0.0/gen/CarbonFootprintBattery.html
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-43 Bytes
(100%)
io.admin-shell.idta.batterypass.digital_nameplate/1.0.0/gen/NameplateBattery.aasx
Binary file not shown.
54 changes: 29 additions & 25 deletions
54
io.admin-shell.idta.batterypass.digital_nameplate/1.0.0/gen/NameplateBattery.html
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-29 Bytes
(100%)
io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.aasx
Binary file not shown.
4 changes: 2 additions & 2 deletions
4
io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.html
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.