Skip to content

docs: update condition tree controls#28

Open
lan17 wants to merge 4 commits intomainfrom
codex/docs-condition-tree-rollout
Open

docs: update condition tree controls#28
lan17 wants to merge 4 commits intomainfrom
codex/docs-condition-tree-rollout

Conversation

@lan17
Copy link
Contributor

@lan17 lan17 commented Mar 12, 2026

Feature work: agentcontrol/agent-control#115

Summary

  • update control-shape examples to use canonical condition instead of flat top-level selector/evaluator
  • refresh the core concepts and models docs to describe condition trees as the public control contract
  • sync integration and example pages with the current example code and remove adjacent stale schema usage

Validation

  • npm run broken-links
  • npx mintlify validate

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Card links check

✅ No broken Card links found. Checked external links in 0.6s

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

✅ Markdown Lint Passed

All markdown files meet the linting standards! 🎉

- `scope` (ControlScope): When to apply the control
- `selector` (ControlSelector): What data to evaluate
- `evaluator` (EvaluatorSpec): How to evaluate
- `condition` (ConditionNode): Recursive condition tree; leaf nodes contain `selector` + `evaluator`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should still explain selector here somewhere, no?

"selector": {"path": "output"},
"evaluator": {
"name": "regex",
"config": {"pattern": r"\\b\\d{3}-\\d{2}-\\d{4}\\b"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct regex for SSN or are we escaping too many times?

"selector": {"path": "output"},
"evaluator": {
"name": "regex",
"config": {"pattern": "\\\\b\\\\d{3}-\\\\d{2}-\\\\d{4}\\\\b"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially same prlblem here. the correct regex should be \b\d{3}-\d{2}-\d{4}\b

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea r\b\d{3}-\d{2}-\d{4}\b

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"selector": { "path": "output" },
"evaluator": {
"name": "regex",
"config": { "pattern": "\\b\\d{3}-\\d{2}-\\d{4}\\b" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the fuck does it keep escaping this shit? it should be \b\d{3}-\d{2}-\d{4}\b and i already fixed it previously: aedbbed

"evaluator": {
"name": "regex",
"config": {
"pattern": "\\b\\d{3}-\\d{2}-\\d{4}\\b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be r "\b\d{3}-\d{2}-\d{4}\b"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pure JSON so these need to be escaped

"evaluator": {
"name": "regex",
"config": {
"pattern": "\\b\\d{3}-\\d{2}-\\d{4}\\b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json only example needs escape

"scripts": {
"dev": "mintlify dev",
"build": "mintlify build",
"build": "mintlify validate",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants