Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Algod Genesis schema to treat timestamp as an optional field across the generated Rust model and the OpenAPI v3 spec, and ensures the conversion pipeline consistently applies this rule when regenerating specs.
Changes:
- Make
Genesis.timestampoptional in the Rust client model (and omit it from serialization when unset). - Remove
timestampfrom theGenesisschema’srequiredlist inalgod.oas3.json. - Add a conversion rule in
convert-openapi.tsto keepGenesis.timestampnon-required during OAS2→OAS3 conversion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/algod_client/src/models/genesis.rs | Changes timestamp from u64 to Option<u64> and updates constructor initialization accordingly. |
| api/specs/algod.oas3.json | Removes timestamp from Genesis.required while retaining it as a schema property. |
| api/scripts/convert-openapi.ts | Adds a requiredFieldTransforms rule to force Genesis.timestamp to be optional in generated OAS3 output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.