Add combined swing mode for horizontal and vertical support#3
Open
Pr0mises wants to merge 4 commits intoanszom:masterfrom
Open
Add combined swing mode for horizontal and vertical support#3Pr0mises wants to merge 4 commits intoanszom:masterfrom
Pr0mises wants to merge 4 commits intoanszom:masterfrom
Conversation
Fixes the off behaviour for home assistant using the off mode
I added a combined swing mode which also adds the possibility to change the horizontal swing mode as well vertical
Owner
|
I'm not sure if this is a good idea. The "combined" property only allows HA to "see" the last attribute that it has changed, but not the other one (for example: if you set "Vertical 2", you can't check what is the horizontal swing mode).
So far the last option seems the most acceptable to me |
Contributor
Author
|
I was thinking about those options but that's how the thingq hacs Integration dealt with it and it wasn't confusing at all. For my part I leave the vertical swing at one position most of the time |
Contributor
Author
|
Good news: Horizontal swings are now supported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the possibility to change the horizontal and vertical swing mode of the AC