Skip to content

Add combined swing mode for horizontal and vertical support#3

Open
Pr0mises wants to merge 4 commits intoanszom:masterfrom
Pr0mises:swing_mode
Open

Add combined swing mode for horizontal and vertical support#3
Pr0mises wants to merge 4 commits intoanszom:masterfrom
Pr0mises:swing_mode

Conversation

@Pr0mises
Copy link
Contributor

This adds the possibility to change the horizontal and vertical swing mode of the AC

Pr0mises added 2 commits July 22, 2024 20:21
Fixes the off behaviour for home assistant using the off mode
I added a combined swing mode which also adds the possibility to change the horizontal swing mode as well vertical
@anszom
Copy link
Owner

anszom commented Jul 31, 2024

I'm not sure if this is a good idea. The "combined" property only allows HA to "see" the last attribute that it has changed, but not the other one (for example: if you set "Vertical 2", you can't check what is the horizontal swing mode).

  • the "right solution" would be to pester HA maintainers to add the other swing mode attribute upstream.
  • as a theoretical alternative, we could have a combined Horizontal x Vertical attribute with 8*9=72 possible values. This - obviously - would not be very practical.
  • the current solution: we expose the other swing mode on MQTT, although in a way which is not directly compatible with current HA.

So far the last option seems the most acceptable to me

@Pr0mises
Copy link
Contributor Author

I was thinking about those options but that's how the thingq hacs Integration dealt with it and it wasn't confusing at all. For my part I leave the vertical swing at one position most of the time

@Pr0mises
Copy link
Contributor Author

Pr0mises commented Jan 3, 2025

Good news:
https://developers.home-assistant.io/blog/2024/12/03/climate-horizontal-swing/

Horizontal swings are now supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants