feat(services/github): implement write returns metadata #6223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Xuanwo
reviewed
May 27, 2025
Comment on lines
+50
to
+60
| if let Ok(body_str) = std::str::from_utf8(body) { | ||
| if let Ok(json) = serde_json::from_str::<serde_json::Value>(body_str) { | ||
| if let Some(content) = json.get("content") { | ||
| if let Some(sha) = content.get("sha").and_then(|v| v.as_str()) { | ||
| metadata.set_version(sha); | ||
| } | ||
| } else if let Some(sha) = json.get("sha").and_then(|v| v.as_str()) { | ||
| metadata.set_version(sha); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Hi, version in opendal means that users can read like op.read_with(path).version(version). Is it possibe for github service to do so?
If it does, maybe we can have a strong typed response struct here so that we don't need to handle it at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #5693 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?