Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion core/src/services/github/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,47 @@ impl GithubWriter {
pub fn new(core: Arc<GithubCore>, path: String) -> Self {
GithubWriter { core, path }
}

fn parse_metadata(headers: &http::HeaderMap, body: &[u8]) -> Result<Metadata> {
let mut metadata = Metadata::default();

if let Some(last_modified) = parse_last_modified(headers)? {
metadata.set_last_modified(last_modified);
}

if let Some(etag) = parse_etag(headers)? {
metadata.set_etag(etag);
}

if let Ok(body_str) = std::str::from_utf8(body) {
if let Ok(json) = serde_json::from_str::<serde_json::Value>(body_str) {
if let Some(content) = json.get("content") {
if let Some(sha) = content.get("sha").and_then(|v| v.as_str()) {
metadata.set_version(sha);
}
} else if let Some(sha) = json.get("sha").and_then(|v| v.as_str()) {
metadata.set_version(sha);
}
}
}
Comment on lines +50 to +60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, version in opendal means that users can read like op.read_with(path).version(version). Is it possibe for github service to do so?

If it does, maybe we can have a strong typed response struct here so that we don't need to handle it at runtime.


Ok(metadata)
}
}

impl oio::OneShotWrite for GithubWriter {
async fn write_once(&self, bs: Buffer) -> Result<Metadata> {
let resp = self.core.upload(&self.path, bs).await?;

let status = resp.status();
let headers = resp.headers().clone();

match status {
StatusCode::OK | StatusCode::CREATED => Ok(Metadata::default()),
StatusCode::OK | StatusCode::CREATED => {
let body = resp.into_body().to_bytes();
let meta = Self::parse_metadata(&headers, &body)?;
Ok(meta)
}
_ => Err(parse_error(resp)),
}
}
Expand Down
Loading