-
Notifications
You must be signed in to change notification settings - Fork 841
Integrate Python driver examples into automated build process #3231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Python driver examples into automated build process #3231
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #3231 +/- ##
=============================================
+ Coverage 76.14% 76.45% +0.31%
- Complexity 13152 13303 +151
=============================================
Files 1084 1092 +8
Lines 65160 67041 +1881
Branches 7285 7378 +93
=============================================
+ Hits 49616 51257 +1641
- Misses 12839 13039 +200
- Partials 2705 2745 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
048955a to
523ac1b
Compare
|
VOTE +1 thanks! |
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
|
Hoping to merge this today, I also forgot to ask for a changelog entry |
Added a generic changelog entry for all GLV examples in 7c3bc33 |
|
Unfortunately I need to ask you to make a separate PR to target these same changes but against |
- Add Python example files to automated testing in docker-compose.yml - Extract environment variables for better configuration management - Improve consistency between root-level and GLV-level examples - Fix environment detection between connections.py and modern_traversals.py
7c3bc33 to
673395f
Compare
#3280) This is a follow-up to #3231 and includes the integration of Python driver examples into the automated build process, as well as the updates needed to make the examples work against the master code. Changes Made: - Added example execution to gremlin-python-integration-tests container in docker-compose.yml - Made server URLs configurable via environment variables - Added configurable vertex labels via VERTEX_LABEL environment variable - Update root-level examples to be consistent with dev-level examples Updates for master: - Updated protocol from WebSocket (ws://) to HTTP - Updated serializer from GraphBinarySerializersV1 to GraphBinarySerializersV4 - Fixed edge creation syntax using __.V() wrapper for TinkerPop 4 from()/to() compatibility - Migrated example authentication from parameters to auth functions
Summary
Integrates Python Gremlin examples into CI to ensure they remain functional in future releases. Examples now execute automatically after integration tests and fail the build if broken.
Changes Made