Enhance exception message for non-object relation #7646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Jan 5, 2026
|
|
||
| if (!\is_object($attributeValue) && null !== $attributeValue) { | ||
| throw new UnexpectedValueException('Unexpected non-object value for to-one relation.'); | ||
| throw new UnexpectedValueException('Unexpected non-object value for to-one relation on class `'.$object::class.'` for attribute `'.$attribute.'`.'); |
Member
There was a problem hiding this comment.
isn't this exposing too much information?
Contributor
Author
There was a problem hiding this comment.
By which you're referring to security related concerns? Disabling showing errors in prod environments imo is a userland concern, implying that exception messages can't be extensive and clear enough. The current message does not really help much in solving the issue.
Contributor
Author
|
The actual root cause of the issue was an entity having a #[ApiResource]
class Foo {
private Bar $bar;
public function isBar(): bool
{
// ...
}
}with the change of this PR would lead to |
Member
|
not sure, probably it should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did receive this exception in an environment out of my control, and message was not helping sufficiently with root cause analysis.