Skip to content

Enhance exception message for non-object relation #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 2 commits into from
Jan 9, 2026
Merged

Enhance exception message for non-object relation #7646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
568d312
Enhance exception message for non-object relation
rvanlaak Jan 5, 2026
93bdc1c
Fix formatting of exception message in AbstractItemNormalizer
rvanlaak Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Serializer/AbstractItemNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@ protected function getAttributeValue(object $object, string $attribute, ?string
$attributeValue = $this->propertyAccessor->getValue($object, $attribute);

if (!\is_object($attributeValue) && null !== $attributeValue) {
throw new UnexpectedValueException('Unexpected non-object value for to-one relation.');
throw new UnexpectedValueException('Unexpected non-object value for to-one relation on class `'.$object::class.'` for attribute `'.$attribute.'`.');
Copy link
Member

@soyuka soyuka Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this exposing too much information?

Copy link
Contributor Author

@rvanlaak rvanlaak Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By which you're referring to security related concerns? Disabling showing errors in prod environments imo is a userland concern, implying that exception messages can't be extensive and clear enough. The current message does not really help much in solving the issue.

}

$resourceClass = $this->resourceClassResolver->getResourceClass($attributeValue, $className);
Expand Down
Loading