Modern python structure #29
Conversation
LecrisUT
force-pushed
the
python/modern
branch
2 times, most recently
from
6978dec to
78a0436
Compare
|
@aradi Could you enable the actions for this PR? |
LecrisUT
force-pushed
the
python/modern
branch
from
b1839ba to
0d85da7
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
python/modern
branch
from
0d85da7 to
f57832b
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
python/modern
branch
from
f57832b to
d119fe2
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
python/modern
branch
from
d119fe2 to
cc34b37
Compare
|
Is there anything else to do to merge this PR? Would it be possible to help? |
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
@eduardz1 if you want to take over this PR and break it up in smaller chunks, I believe it would help here. I can offer assistance with reviews and offer any suggestions for improvements. Currently my attention is split across too many projects so I can't actively work on this right now.
| node: $Format:%H$ | ||
| node-date: $Format:%cI$ | ||
| describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$ | ||
| ref-names: $Format:%D$ |
There was a problem hiding this comment.
| ref-names: $Format:%D$ |
This line must be removed
| @@ -0,0 +1,7 @@ | |||
| version: 2 | |||
| updates: | |||
There was a problem hiding this comment.
After having had more experience, I would now recommend against dependabot for projects that are not in constant sprint. Instead renovatebot is a much better solution that adapts better to the particular project's development cadence.
| with: | ||
| ref: ${{ inputs.ref }} | ||
| - name: Build package | ||
| run: pipx run build |
There was a problem hiding this comment.
This workflow should be revisited to use hynek/build-and-inspect-python-package
|
Sorry, I was really distracted from Fypp lately due to other projects. @eduardz1 Welcome on board and thanks for your interest. I'd wish to have smaller PR's as @LecrisUT suggested. Especially, because this one changes several stuff at the same time: Packaging, testing and introduces even an API-break (by using |
3 participants
python -m fyppModern pytest structure(Postponed for later)Better Sphinx support(Postponed for later)