fix #256 from arquillian / arquillian.github.com#8
Open
pehunka wants to merge 1 commit intoarquillian:masterfrom
pehunka:master
Open
fix #256 from arquillian / arquillian.github.com#8pehunka wants to merge 1 commit intoarquillian:masterfrom pehunka:master
pehunka wants to merge 1 commit intoarquillian:masterfrom
pehunka:master
Conversation
- SingletoneOrderRepository list orders was empty because of wrong pass by reference in basket.placeOrder() - new Assert that ensure that list inside SingletoneOrderRepository contains items from basket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basket class contains
List<String>of items. Functionbasket.placeOrder()pass this item's list to another list inside SingletonOrderRepository.class and than this list is cleared viaitems.clear(). This is problem because value is pass via reference copy and list inside SingletonOrderRepository is cleared also.Arquillian's tests looks ok on first sight because they testing only size not what they are really holding inside.
You need eather
items = new ArrayList<String>()instead ofitems.clear()inside Basket.classor
orders.add(new ArrayList<String>(order));instead of
orders.add(order);inside SingletonOrderRepository.class