Skip to content

Add 1 second delay before showing git blame popover #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehmetozguldev merged 1 commit into from
Dec 19, 2025
Merged

Add 1 second delay before showing git blame popover #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/features/version-control/git/components/inline-git-blame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const InlineGitBlame = ({ blameLine, className }: InlineGitBlameProps) =>
const triggerRef = useRef<HTMLDivElement>(null);
const popoverRef = useRef<HTMLDivElement>(null);
const hideTimeoutRef = useRef<NodeJS.Timeout | null>(null);
const showTimeoutRef = useRef<NodeJS.Timeout | null>(null);
const documentRef = useRef(document);
const { settings } = useSettingsStore();
const [isCopied, setIsCopied] = useState(false);
Expand All @@ -41,6 +42,13 @@ export const InlineGitBlame = ({ blameLine, className }: InlineGitBlameProps) =>
}
}, []);

const clearShowTimeout = useCallback(() => {
if (showTimeoutRef.current) {
clearTimeout(showTimeoutRef.current);
showTimeoutRef.current = null;
}
}, []);

const scheduleHide = useCallback(() => {
clearHideTimeout();
hideTimeoutRef.current = setTimeout(() => {
Expand Down Expand Up @@ -81,17 +89,21 @@ export const InlineGitBlame = ({ blameLine, className }: InlineGitBlameProps) =>

const showPopover = useCallback(() => {
clearHideTimeout();
if (!showCard) {
updatePosition();
setShowCard(true);
showOverlay("git-blame");
if (!showCard && !showTimeoutRef.current) {
showTimeoutRef.current = setTimeout(() => {
updatePosition();
setShowCard(true);
showOverlay("git-blame");
showTimeoutRef.current = null;
}, 1000);
}
}, [clearHideTimeout, showCard, updatePosition, showOverlay]);

const hidePopover = useCallback(() => {
clearShowTimeout();
scheduleHide();
hideOverlay("git-blame");
}, [scheduleHide, hideOverlay]);
}, [clearShowTimeout, scheduleHide, hideOverlay]);

const handleCopyCommitHash = useCallback(
async (e: React.MouseEvent) => {
Expand Down Expand Up @@ -244,12 +256,13 @@ export const InlineGitBlame = ({ blameLine, className }: InlineGitBlameProps) =>
};
}, [showCard]);

// Clean up timeout on unmount
// Clean up timeouts on unmount
useEffect(() => {
return () => {
clearHideTimeout();
clearShowTimeout();
};
}, [clearHideTimeout]);
}, [clearHideTimeout, clearShowTimeout]);

return (
<div ref={triggerRef} className="relative inline-flex">
Expand Down