Fix for 311 client test retries due to its error event emission behavior#656
Open
bretambrose wants to merge 3 commits intomainfrom
Open
Fix for 311 client test retries due to its error event emission behavior#656bretambrose wants to merge 3 commits intomainfrom
bretambrose wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 311 client emits 'error' events which, if uncaught, abort the node process. Update 311 tests that do not handle this behavior to now reject a top-level promise with the error so that the retry logic can be applied.
Ex: https://github.com/awslabs/aws-crt-nodejs/actions/runs/18954090562/job/54126271186?pr=653
(Disable whitespace changes to make the CR easier on the eyes)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.