Skip to content

Fix for 311 client test retries due to its error event emission behavior #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bretambrose wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for 311 client test retries due to its error event emission behavior #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
072cd28
Fix for 311 client test retries due to its error event emission behavior
bretambrose Oct 31, 2025
aac0273
Merge branch 'main' into ErrorEventEscape
bretambrose Mar 3, 2026
dc78a6b
Merge branch 'main' into ErrorEventEscape
bretambrose Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 81 additions & 62 deletions lib/browser/aws_iot.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@ import {once} from "events";

jest.setTimeout(30000);

async function doSuccessfulConnectTest(builder: aws_iot_mqtt311.AwsIotMqttConnectionConfigBuilder) : Promise<void> {
return new Promise(async (resolve, reject) => {
let config = builder.build();
let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);
connection.on('error', (e) => {
reject(e);
});

await connection.connect();
await connection.disconnect();

resolve();
});
}

test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_custom_auth_unsigned())('Aws Iot Core Mqtt over websockets with Non-Signing Custom Auth - Connection Success', async () => {
await retry.networkTimeoutRetryWrapper( async () => {
let builder = aws_iot_mqtt311.AwsIotMqttConnectionConfigBuilder.new_default_builder();
Expand All @@ -24,11 +40,7 @@ test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_custom_auth_unsi
)
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
let config = builder.build();
let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);
await connection.connect();
await connection.disconnect();
return doSuccessfulConnectTest(builder);
})
});

Expand All @@ -45,11 +57,7 @@ test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_custom_auth_sign
)
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
let config = builder.build();
let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);
await connection.connect();
await connection.disconnect();
return doSuccessfulConnectTest(builder);
})
});

Expand All @@ -66,68 +74,78 @@ test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_custom_auth_sign
)
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
let config = builder.build();
let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);
await connection.connect();
await connection.disconnect();
return doSuccessfulConnectTest(builder);
})
});

test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_cred())('MQTT Browser Websocket Connect/Disconnect', async () => {
await retry.networkTimeoutRetryWrapper( async () => {
let builder = aws_iot_mqtt311.AwsIotMqttConnectionConfigBuilder.new_with_websockets();
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
builder.with_credentials(
test_env.AWS_IOT_ENV.MQTT311_REGION,
test_env.AWS_IOT_ENV.MQTT311_CRED_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SECRET_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SESSION_TOKEN
);
let config = builder.build();
let client = new mqtt311.MqttClient(new io.ClientBootstrap());
let connection = client.new_connection(config);

const connectionSuccess = once(connection, "connection_success");
await connection.connect();

let connectionSuccessEvent: mqtt311.OnConnectionSuccessResult = (await connectionSuccess)[0];
expect(connectionSuccessEvent.session_present).toBeFalsy();
expect(connectionSuccessEvent.reason_code).toBeUndefined();

const closed = once(connection, "closed");
await connection.disconnect();
await closed;
let errorEventWrapper: Promise<void> = new Promise(async (resolve, reject) => {
let builder = aws_iot_mqtt311.AwsIotMqttConnectionConfigBuilder.new_with_websockets();
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
builder.with_credentials(
test_env.AWS_IOT_ENV.MQTT311_REGION,
test_env.AWS_IOT_ENV.MQTT311_CRED_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SECRET_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SESSION_TOKEN
);
let config = builder.build();
let client = new mqtt311.MqttClient(new io.ClientBootstrap());
let connection = client.new_connection(config);
connection.on('error', (e) => { reject(e); });

const connectionSuccess = once(connection, "connection_success");
await connection.connect();

let connectionSuccessEvent: mqtt311.OnConnectionSuccessResult = (await connectionSuccess)[0];
expect(connectionSuccessEvent.session_present).toBeFalsy();
expect(connectionSuccessEvent.reason_code).toBeUndefined();

const closed = once(connection, "closed");
await connection.disconnect();
await closed;

resolve();
});

return errorEventWrapper;
})
});

test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_cred())('MQTT Browser Websocket Connect/Disconnect No Bootstrap', async () => {
await retry.networkTimeoutRetryWrapper( async () => {
let builder = aws_iot_mqtt311.AwsIotMqttConnectionConfigBuilder.new_with_websockets();
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
builder.with_credentials(
test_env.AWS_IOT_ENV.MQTT311_REGION,
test_env.AWS_IOT_ENV.MQTT311_CRED_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SECRET_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SESSION_TOKEN
);
let config = builder.build();

let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);

const connectionSuccess = once(connection, "connection_success");
await connection.connect();

let connectionSuccessEvent: mqtt311.OnConnectionSuccessResult = (await connectionSuccess)[0];
expect(connectionSuccessEvent.session_present).toBeFalsy();
expect(connectionSuccessEvent.reason_code).toBeUndefined();

const closed = once(connection, "closed");
await connection.disconnect();
await closed;
let errorEventWrapper: Promise<void> = new Promise(async (resolve, reject) => {
let builder = aws_iot_mqtt311.AwsIotMqttConnectionConfigBuilder.new_with_websockets();
builder.with_endpoint(test_env.AWS_IOT_ENV.MQTT311_HOST);
builder.with_client_id(`node-mqtt-unit-test-${uuid()}`)
builder.with_credentials(
test_env.AWS_IOT_ENV.MQTT311_REGION,
test_env.AWS_IOT_ENV.MQTT311_CRED_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SECRET_ACCESS_KEY,
test_env.AWS_IOT_ENV.MQTT311_CRED_SESSION_TOKEN
);
let config = builder.build();

let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);
connection.on('error', (e) => { reject(e); });

const connectionSuccess = once(connection, "connection_success");
await connection.connect();

let connectionSuccessEvent: mqtt311.OnConnectionSuccessResult = (await connectionSuccess)[0];
expect(connectionSuccessEvent.session_present).toBeFalsy();
expect(connectionSuccessEvent.reason_code).toBeUndefined();

const closed = once(connection, "closed");
await connection.disconnect();
await closed;

resolve();
});

return errorEventWrapper;
})
});

Expand All @@ -147,6 +165,7 @@ test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_custom_auth_sign
let config = builder.build();
let client = new mqtt311.MqttClient();
let connection = client.new_connection(config);
connection.on('error', (e) => {});

const connectionFailure = once(connection, "connection_failure")
try {
Expand Down
Loading
Loading