修复modal show的时候 重复绑定scroll resize事件#29
Open
ccpend wants to merge 3 commits intobaixing:masterfrom
ccpend:modalfix
Open
修复modal show的时候 重复绑定scroll resize事件#29ccpend wants to merge 3 commits intobaixing:masterfrom ccpend:modalfix
ccpend wants to merge 3 commits intobaixing:masterfrom
ccpend:modalfix
Conversation
|
没看懂。。。 如果只是解决重复绑定，为啥不是在hide里解绑？ |
Author
|
如果在hide中解绑，需要额外设置事件的命名空间。 |
|
额外设置这个不觉得是问题。 不过多modal是个问题。现在是可以多modal的吗？我个人觉得多modal本身似乎应该不允许才对。而且现有实现似乎也没考虑过多modal，比如遮罩也只有一个。 |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.