Skip to content

修复modal show的时候 重复绑定scroll resize事件 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccpend wants to merge 3 commits into
base: master
Choose a base branch
from
Open

修复modal show的时候 重复绑定scroll resize事件 #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
513b431
修复modal show的时候 重复绑定scroll resize事件
ccpend May 20, 2015
59eeefa
reset
ccpend May 20, 2015
2f79026
修复modal show的时候 重复绑定scroll resize事件
ccpend May 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/js/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@
this.options = options
this.$element = $(content)
.delegate('[data-dismiss="modal"]', 'click.dismiss.modal', $.proxy(this.hide, this))
// edit by @liuning-geek
this.isPushSetPosQueue = false;
}

Modal.prototype = {
Expand Down Expand Up @@ -135,9 +137,12 @@
// add by @sofish
// set margin to adjust the window
this.setPos(that.$element);
$(window).bind('scroll resize', function(){
that.setPos(that.$element);
});

// edit by @liuning-geek
if (!that.isPushSetPosQueue) {
that.isPushSetPosQueue = true;
pushSetPosQueue(function() { that.setPos(that.$element); });
}

if(data) data['setPos'] = this.setPos;

Expand Down Expand Up @@ -192,10 +197,28 @@

}

/* MODAL PRIVATE PROPERTY
* ===================== */

// add by @liuning-geek
var setPosQueue = [];

/* MODAL PRIVATE METHODS
* ===================== */

// add by @liuning-geek
function pushSetPosQueue(func) {
// If this is the first time a push in the window binding events
if (setPosQueue.length === 0) {
$(window).bind('scroll resize', function(){
for (var i = 0, len = setPosQueue.length; i < len; i++)
setPosQueue[i]();
});
}

setPosQueue.push(func);
}

function hideWithTransition() {
var that = this
, timeout = setTimeout(function () {
Expand Down