Open
Conversation
iann460
changed the title
iann460
changed the title
iann460
changed the title
…ntBasic component
…handling and positioning logic
MrDirkelz
reviewed
Feb 27, 2026
Collaborator
MrDirkelz
left a comment
MrDirkelz
left a comment
There was a problem hiding this comment.
Why would LDropdown have had to been changed?
ivanslabbert
reviewed
Mar 2, 2026
| v-if="(content as any).copyright" | ||
| class="text-center text-xs text-zinc-500 dark:text-slate-300" | ||
| > | ||
| {{ (content as any).copyright }} |
Contributor
There was a problem hiding this comment.
we should only in very exeptional cases cast a variable as "any" as this bypasses type checking and can cause runtime errors.
Contributor
There was a problem hiding this comment.
These changes should not be part of this ticket, as it is not solving the issue described by the ticket. Other fixes should be submitted as separate tickets.
| name="copyright" | ||
| :disabled="disabled" | ||
| inputType="textarea" | ||
| placeholder="© 2024 My Company" |
Contributor
There was a problem hiding this comment.
I think we can remove the placeholder.
| :disabled="disabled" | ||
| inputType="textarea" | ||
| placeholder="© 2024 My Company" | ||
| v-model="(content as any).copyright" |
Contributor
There was a problem hiding this comment.
See above comment on casting as "any"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1312