-
Notifications
You must be signed in to change notification settings - Fork 2
Add content copyright field (#1312) #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iann460
wants to merge
7
commits into
main
Choose a base branch
from
1306-cms-app-add-content-copyright-field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
efee557
Reduce the padding at the top (#1312)
iann460 7c851a6
feat: Add copyright field to content editing form
iann460 aaf88c0
feat: Add optional copyright field to ContentDto and update EditConte…
iann460 183e2df
feat: Display copyright information in SingleContent component
iann460 25ea424
Added copyright type
iann460 73e7090
feat: Enhance LDropdown and LCombobox components with improved event …
MrDirkelz f24973d
Remove the changes LDropdown.vue
ChrisTouo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -429,6 +429,19 @@ const clearExpiryDate = () => { | |
| </div> | ||
| </div> | ||
|
|
||
| <!-- Copyright --> | ||
| <div class="mt-2 flex items-center gap-5"> | ||
| <FormLabel class="whitespace-nowrap">Copyright</FormLabel> | ||
| <LInput | ||
| name="copyright" | ||
| :disabled="disabled" | ||
| inputType="textarea" | ||
| placeholder="© 2024 My Company" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can remove the placeholder. |
||
| v-model="(content as any).copyright" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above comment on casting as "any" |
||
| class="flex-1" | ||
| /> | ||
| </div> | ||
|
|
||
| <!-- Status --> | ||
| <div class="mt-2 flex items-center justify-between gap-2"> | ||
| <FormLabel class="self-start py-2">Status</FormLabel> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should only in very exeptional cases cast a variable as "any" as this bypasses type checking and can cause runtime errors.