add: Support hex notation by 0xabcd when converting to bignum values#1
Open
BenBE wants to merge 1 commit intobeargiles:masterfrom
Open
add: Support hex notation by 0xabcd when converting to bignum values#1BenBE wants to merge 1 commit intobeargiles:masterfrom
BenBE wants to merge 1 commit intobeargiles:masterfrom
Conversation
|
Ohh, I see what asc2bn does,.
That's brilliant for coercion. Though I think we should keep the same behavior for in/out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As some if not most big numbers are usually given in hex it's nice to have a direct way of importing/converting them from string. Given that parsing hex to binary is even much faster than base conversion from base 10 to base 256 (for binary) it's highly recommended to prefer hex input for performance.
For output both formats have their advantages ...