WIP: FSR3 #21669

cwfitzgerald · 2025-10-27T23:05:44Z

Objective

Closes Support for AMD FSR 2.0 #5232
Integrate FSR3 cross platform.

Solution

Describe the solution used to achieve the objective above.

Testing

Did you test these changes? If so, how?
Are there any parts that need more testing?
How can other people (reviewers) test your changes? Is there anything specific they need to know?
If relevant, what platforms did you test these changes on, and are there any important ones you can't test?

Showcase

This section is optional. If this PR does not include a visual change or does not add a new feature, you can delete this section.

Help others understand the result of this PR by showcasing your awesome work!
If this PR adds a new feature or public API, consider adding a brief pseudo-code snippet of it in action
If this PR includes a visual change, consider adding a screenshot, GIF, or video
- If you want, you could even include a before/after comparison!
If the Migration Guide adequately covers the changes, you can delete this section

While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:

Click to view showcase

println!("My super cool code.");

github-actions · 2025-10-27T23:05:53Z

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

github-actions · 2025-10-27T23:12:09Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21669

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

atlv24 · 2025-10-27T23:19:49Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+            camera_fov_y,
+            camera_near,
+            camera_far,
+            frame_time_delta: time.delta_secs() * 1000.0,


why * 1000.0?

Milliseconds

atlv24 · 2025-10-27T23:28:34Z

examples/3d/anti_aliasing.rs

    >,
 ) {
    #[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))]
    let (projection, fxaa, smaa, taa, cas, msaa, dlss) = *camera;


probably want fsr in both code paths, otherwise dlss would kind of be a negative feature?

JMS55 · 2025-10-27T23:27:28Z

examples/3d/anti_aliasing.rs

+    MipBias,
+    DepthPrepass,
+    MotionVectorPrepass,
+    Fsr3,


Nit: Move Fsr3 to the front of the list

JMS55 · 2025-10-27T23:28:09Z

crates/bevy_core_pipeline/src/core_3d/mod.rs

        MotionBlur,
        Taa,
+        Fsr3,
        DlssSuperResolution,


Idk if we need a generic TSR label or something long term, but for now this is fine.

JMS55 · 2025-10-27T23:31:41Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+//! AMD FidelityFX Super Resolution 3 (FSR3).
+//!
+//! FSR3 is a temporal upscaling and anti-aliasing technique that uses
+//! machine learning-based upscaling to render at a lower resolution


Err it doesn't use ML?

Oops trusted copilot's suggestions too much

JMS55 · 2025-10-27T23:33:23Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+/// Pros:
+/// * Much better performance by rendering at lower resolution
+/// * High quality temporal anti-aliasing
+/// * Works on AMD, NVIDIA, and Intel GPUs


Web support?

Yes but future, I'll revise this

Also what about macOS / android / iOS?

JMS55 · 2025-10-27T23:33:46Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+/// * Much better performance by rendering at lower resolution
+/// * High quality temporal anti-aliasing
+/// * Works on AMD, NVIDIA, and Intel GPUs
+/// * Includes optional sharpening pass


Does the optional sharpening pass make sense to include? We already have RCAS built into Bevy.

I'd rather people use that, as it's compatible with TAA/DLSS, and will play better once we make a generic TSR abstraction.

I haven't actually wired it up yet in FSR, but it reuses an existing pass, so I would expect it to be faster.

JMS55 · 2025-10-27T23:38:20Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+                MainPassResolutionOverride(render_resolution),
+            ));
+        } else {
+            // Update resolution override in case it changed


I haven't sat down to think about it, but why is this structured differently than the DLSS prepare code?

I was modeling after TAA more than DLSS, I'll have a better look how this can be made more consistent

Yeah, I would look at the DLSS code and copy that, it's much more 1:1 with how FSR should work.

JMS55 · 2025-10-27T23:38:42Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+            .add_systems(
+                Render,
+                (
+                    prepare_fsr3_jitter_and_context.in_set(RenderSystems::ManageViews),


Needs .before(prepare_view_targets), since you modify the main camera usages.

JMS55 · 2025-10-27T23:39:17Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+    mut commands: Commands,
+    mut texture_cache: ResMut<TextureCache>,
+    render_device: Res<RenderDevice>,
+    views: Query<(Entity, &ExtractedCamera, &ExtractedView, &Fsr3), With<Fsr3>>,


You don't need With if you already have &Fsr3 in your query.

JMS55 · 2025-10-27T23:41:01Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+    render_device: Res<RenderDevice>,
+    views: Query<(Entity, &ExtractedCamera, &ExtractedView, &Fsr3), With<Fsr3>>,
+) {
+    for (entity, camera, view, fsr3) in &views {


Please follow the newer pattern for texture-prepare systems as used in https://github.com/bevyengine/bevy/blob/main/crates/bevy_solari/src/realtime/prepare.rs (you can just store TextureView now as textures can be retrieved from views, I should update the solari code)

JMS55 · 2025-10-27T23:42:15Z

crates/bevy_anti_alias/src/fsr3/mod.rs

+///
+/// See [`Fsr3`] for more details.
+#[derive(Default)]
+pub struct Fsr3Plugin;


Please split this file up to match the DLSS file structure (mode, extract, prepare, node).

WIP: FSR3

55927c2

atlv24 reviewed Oct 27, 2025

View reviewed changes

JMS55 suggested changes Oct 27, 2025

View reviewed changes

Uh oh!

Uh oh!

WIP: FSR3 #21669

Are you sure you want to change the base?

WIP: FSR3 #21669

Conversation

cwfitzgerald commented Oct 27, 2025

Objective

Solution

Testing

Showcase

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants