refactor: register the pre-built protoc toolchain #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stagnation
force-pushed
the
feature/refactor-register-the-pre-built-protoc-toolchain
branch
from
101c968 to
fd3c6b5
Compare
|
This isn't supposed to be needed - I changed toolchains_protoc instructions: aspect-build/toolchains_protoc#75 Note the new README content in that PR - this is one way to fix it, but the other is simply to move toolchains_protoc earlier in the Note, the protobuf team broke it by registering their from-source toolchain on the same |
Collaborator
Author
|
Thanks for the help in troubleshooting. Still a bit annoying to have order dependence, but it is clear why calls to |
By calling the protoc toolchain module first its registered toolchain wins for compiling protoc. This follows discussions in buildbarn/bb-storage#248
stagnation
force-pushed
the
feature/refactor-register-the-pre-built-protoc-toolchain
branch
from
fd3c6b5 to
6262699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions in buildbarn/bb-storage#248 we must register the toolchain as well. I don't know if this was always an oversight or the behavior changed.