-
Notifications
You must be signed in to change notification settings - Fork 116
refactor: use pre-built protoc binary #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33faf3 to
cd8330f
Compare
Saves a bunch of time in analysis and execution when there is a cache miss on protoc, as well as avoiding a bunch of gcc logspam.
Contributor
|
Great! We saw the expected improvements in the deployments repo, and it helped with some Windows issues we had at the time. I then forgot to add it to the other repos: buildbarn/bb-deployments#139 |
EdSchouten
reviewed
Jun 8, 2025
stagnation
added a commit
to buildbarn/bb-deployments
that referenced
this pull request
Jun 9, 2025
Following discussions in buildbarn/bb-storage#248 we must register the toolchain as well. I don't know if this was always an oversight or the behavior changed.
stagnation
added a commit
to buildbarn/bb-deployments
that referenced
this pull request
Jun 9, 2025
Following discussions in buildbarn/bb-storage#248 we must register the toolchain as well. I don't know if this was always an oversight or the behavior changed.
EdSchouten
reviewed
Jun 9, 2025
Member
|
Thanks! |
stagnation
added a commit
to buildbarn/bb-deployments
that referenced
this pull request
Jun 13, 2025
By calling the protoc toolchain module first its registered toolchain wins for compiling protoc. This follows discussions in buildbarn/bb-storage#248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves a bunch of time in analysis and execution when there is a cache miss on protoc, as well as avoiding a bunch of gcc logspam.
For example a recent commit on master took 3m 54s to
Run
bazel run @com_github_bazelbuild_buildtools//:buildifierhttps://github.com/buildbarn/bb-storage/actions/runs/15302599382/job/43046869873
and printed 256 lines of log output such as
Nearly all the time and log output is attributed to compiling
cc_binary @protobuf//:protoc