Skip to content

Fix Behat execute helper method arguments. #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewhilton merged 2 commits into from
Nov 7, 2025
Merged

Fix Behat execute helper method arguments. #920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c4c2d8
Fix Behat execute helper method arguments.
paulholden Sep 26, 2025
9f906d4
[#919] Fix method args
matthewhilton Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions tests/behat/behat_auth_saml2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,26 +379,22 @@ private function reset_moodle_session() {
}

/**
* Execute.
* Helper function to execute api in a given context.
*
* @param string $contextapi context in which api is defined.
* @param array $params list of params to pass.
* Note: The contextapi does not support a callback.
*
* @param string|array $contextapi context in which api is defined.
* @param mixed $params list of params to pass or a single parameter
*/
protected function execute($contextapi, $params = []) {
protected function execute(
string|array $contextapi,
mixed $params = [],
): void {
global $CFG;

// We allow usage of depricated behat steps for now.
$CFG->behat_usedeprecated = true;

// If newer Moodle, use the correct version.
if ($CFG->branch >= 29) {
return parent::execute($contextapi, $params);
}

// Backported for Moodle 27 and 28.
list($class, $method) = explode("::", $contextapi);
$object = behat_context_helper::get($class);
$object->setMinkParameter('base_url', $CFG->wwwroot);
return call_user_func_array([$object, $method], $params);
parent::execute($contextapi, $params);
}
}
Loading