Fix Behat execute helper method arguments. #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream changes in MDL-86231 amended the method contract. Also remove some old backwards compat code, given this version of the plugin has explicit support only from 5.0. Fixes #917.
paulholden
approved these changes
Oct 15, 2025
Contributor
|
@danmarsden Hope you don't mind, Ive got another PR but the CI is still red there because this isn't merged yet, and this was just stuck on a phpdoc change, so I pushed a commit here to fix that. Im confident the CI will be green now Assuming the CI is green, i'll merge this in |
matthewhilton
approved these changes
Nov 7, 2025
Contributor
|
CI is still red however this is due to recently changed code standards, tests are running & passing now - i'll fix the remaining ci issues in my own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes in MDL-86231 amended the method contract. Also remove some old backwards compat code, given this version of the plugin has explicit support only from 5.0.
Fixes #917.