refactor: update to new evnode flag

[julienrbrt]

ref: evstack/ev-node#2637

Summary by CodeRabbit

• Chores
  • Renamed the CLI flag for the aggregator signer path to --evnode.signer.signer_path.
  • Signer path still resolves from the node’s config directory and is supplied alongside the aggregator and passphrase options.
  • No behavioral or workflow changes beyond adopting the new flag name.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between be11399 and affb9dd.

📒 Files selected for processing (1)

• framework/docker/evstack/node.go (2 hunks)

 ______________________________________________________________________________________________________________________________________________________
< Why do you need code reviews? dB/dt = ∇ × Bv: The proliferation rate of bugs (dB/dt) equals the curl of the bug vector field (Bv). It's simple math. >
 ------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Walkthrough

Updated the CLI flag for the signer path from --evnode.signer.path to --evnode.signer.signer_path in evstack aggregator node setup, adjusting both initialization and container start command construction. No other logic or control flow was changed.

Changes

Cohort / File(s)	Summary
CLI flag update (signer path) framework/docker/evstack/node.go	Replaced occurrences of --evnode.signer.path with --evnode.signer.signer_path in Init and createEvstackContainer start command construction; signerPath still derived from HomeDir()/config.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “refactor: update to new evnode flag” succinctly summarizes the primary change of renaming the CLI flag for the evnode signer path, is concise without extraneous details, and clearly conveys the intent of the refactor to anyone scanning the commit history.
Description Check	✅ Passed	The description, though minimal, directly references the upstream pull request that introduced the evnode flag change, making it clearly related to this changeset rather than off-topic.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Poem

A hop, a bop—two dashes align,
I tweak a flag, make pathways fine.
From signer.path to signer_path,
The carrots stack without a flap.
Containers hum, configs in tow—
Thump-thump, good flags help systems go! 🥕✨

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

framework/docker/evstack/node.go (1)

105-112: Deduplicate aggregator flags (single helper to avoid future drift)

Use one helper so future flag renames happen in one place.

Apply:

@@
 func (n *Node) Init(ctx context.Context, initArguments ...string) error {
@@
-  if n.isAggregator() {
-    signerPath := filepath.Join(n.HomeDir(), "config")
-    cmd = append(cmd,
-      "--evnode.node.aggregator",
-      "--evnode.signer.passphrase="+n.cfg.AggregatorPassphrase, //nolint:gosec // used for testing only
-      "--evnode.signer.signer_path="+signerPath)
-  }
+  if n.isAggregator() {
+    cmd = append(cmd, n.aggregatorFlags()...)
+  }
@@
 func (n *Node) createEvstackContainer(ctx context.Context, additionalStartArgs ...string) error {
@@
-  if n.isAggregator() {
-    signerPath := filepath.Join(n.HomeDir(), "config")
-    startCmd = append(startCmd,
-      "--evnode.node.aggregator",
-      "--evnode.signer.passphrase="+n.cfg.AggregatorPassphrase, //nolint:gosec // used for testing only
-      "--evnode.signer.signer_path="+signerPath)
-  }
+  if n.isAggregator() {
+    startCmd = append(startCmd, n.aggregatorFlags()...)
+  }

Add nearby:

func (n *Node) aggregatorFlags() []string {
  signerPath := filepath.Join(n.HomeDir(), "config")
  return []string{
    "--evnode.node.aggregator",
    "--evnode.signer.passphrase=" + n.cfg.AggregatorPassphrase, //nolint:gosec // tests only
    "--evnode.signer.signer_path=" + signerPath,
  }
}

Also applies to: 151-156

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 732fc83 and be11399.

📒 Files selected for processing (1)

• framework/docker/evstack/node.go (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

framework/docker/evstack/node.go (3)

framework/docker/evstack/node_config.go (2)

• IsAggregator (10-21)
• b (40-43)

framework/docker/evstack_test.go (1)

• TestEvstack (18-135)

framework/docker/evstack/chain_builder.go (3)

• b (87-90)
• t (15-40)
• b (111-114)

🔇 Additional comments (2)

framework/docker/evstack/node.go (2)

155-156: Start path updated consistently

Start command now uses --evnode.signer.signer_path as well; consistent with upstream constants/docs. (github.com)

---

111-112: Confirm CI ev-node image includes PR #2637
No occurrences of the old --evnode.signer.path flag remain in Go code; please verify that your CI (workflows, Dockerfiles, Jenkinsfiles, etc.) pulls an evstack/ev-node image at or after PR evstack/ev-node#2637, or tests may fail on the renamed flag.

[chatton]

🫡

[chatton]

@julienrbrt there will be a bunch of breaking changes in the next tag, not too many I think that will just effect evnode but either I can help implement them or you can use the tests in this repo as a reference. Mainly around the construction of the evnodes themselves, it's using the builder pattern now to be consistent with how things work in celestia-app

[chatton]

@julienrbrt it looks like tests still failing, need to check which image is being used

[julienrbrt]

@julienrbrt it looks like --evnode.signer.signer_path is not the correct flag 🤔

It just got merged on main. It should be correct now :)

[chatton]

@julienrbrt looks good now 🚀