Skip to content

fix(config): correct signer flag#2637

Merged
tac0turtle merged 5 commits intomainfrom
julien/fix-signer
Sep 10, 2025
Merged

fix(config): correct signer flag#2637
tac0turtle merged 5 commits intomainfrom
julien/fix-signer

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 9, 2025

Closes: #2603

Flags need to match the file structure for binding to work.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedSep 9, 2025, 4:28 PM

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses naming inconsistencies within the project's configuration system. It standardizes the primary configuration file name and refines internal flag definitions, leading to a more consistent and user-friendly experience when interacting with the application's settings.

Highlights

  • Configuration File Renaming: The primary configuration file name has been updated from "evolve.yaml" to "evnode.yml" across various application initialization commands, error messages, and documentation files to ensure consistency.
  • Signer Flag Correction: The internal constant names for signer configuration flags, FlagSignerType and FlagSignerPath, have been corrected to signer.signer_type and signer.signer_path respectively, improving clarity and adherence to naming conventions.
  • Documentation Updates: All relevant documentation files have been updated to reflect the new configuration file name and include minor formatting adjustments for improved readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on renaming the configuration file from evolve.yaml to evnode.yml across the codebase and documentation. It also corrects the command-line flags for the signer configuration to be consistent with the struct field names. My review has identified a couple of areas in the documentation that were missed during these updates and require correction for consistency and accuracy. Overall, the changes are good but need these documentation fixes to be complete.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-10 07:36 UTC

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.15%. Comparing base (0584153) to head (592ac07).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   69.17%   69.15%   -0.03%     
==========================================
  Files          74       74              
  Lines        7803     7803              
==========================================
- Hits         5398     5396       -2     
- Misses       1955     1957       +2     
  Partials      450      450              
Flag Coverage Δ
combined 69.15% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tac0turtle
tac0turtle previously approved these changes Sep 9, 2025
@tac0turtle
Copy link
Contributor

can you update docs as well

@julienrbrt
Copy link
Member Author

E2E tests are currently failing because of celestiaorg/tastora#112

@tac0turtle tac0turtle merged commit 67b726e into main Sep 10, 2025
26 of 31 checks passed
@tac0turtle tac0turtle deleted the julien/fix-signer branch September 10, 2025 07:35
@github-project-automation github-project-automation bot moved this to Done in Evolve Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Flag evnode.signer.path not respected

2 participants