Optimize Multisig submitAndConfirm

[aaronmgdr]

Description

Reports that it took very long/timed out when approving a transaction

Other changes

adds ability to specify if submitting or confirming by passing --submit or --multisigTx NUMBER

Tested.

How to QA

try to approve something

Related issues

---

PR-Codex overview

This PR focuses on enhancing the multisig transaction approval process in the @celo/contractkit and @celo/celocli packages by introducing new methods and command flags for better control over transaction submission and confirmation.

Detailed summary

• Updated transaction submission logic to search only non-executed transactions.
• Added submitTransaction method in MultiSigWrapper for manual submission.
• Introduced --submit and --multisigTx flags in governance:approve command for enhanced control.
• Added checks in tests to ensure proper validation of multisig transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

🦋 Changeset detected

Latest commit: e58d98f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@celo/celocli	Minor
@celo/contractkit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
require('@celo/actions') (cjs)	98.85 KB (0%)
import * from '@celo/actions' (esm)	23.55 KB (0%)
import { resolveAddress } from '@celo/actions' (esm)	23.49 KB (0%)
import { getGasPriceOnCelo } from '@celo/actions' (esm)	73 B (0%)
import { getAccountsContract } from '@celo/actions/contracts/accounts' (esm)	46.11 KB (0%)
import * from '@celo/actions/staking' (esm)	50.66 KB (0%)

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.61%. Comparing base (d5d9043) to head (e58d98f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   69.63%   69.61%   -0.03%     
==========================================
  Files         150      150              
  Lines        7071     7075       +4     
  Branches     1153     1157       +4     
==========================================
+ Hits         4924     4925       +1     
+ Misses       2055     2051       -4     
- Partials       92       99       +7     

Components	Coverage Δ
celocli	∅ <ø> (∅)
sdk	69.12% <40.00%> (-0.04%)	⬇️
wallets	73.14% <ø> (ø)
viem-sdks	94.15% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[martinvol]

I tested this, it got to the point where it doesn't time out, but still took about a minute and did a ton of RPC requests