[Refactor] #160 - 멘토링 피드백 #188
Open
+8
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneTen19
approved these changes
Nov 21, 2025
Member
OneTen19
left a comment
OneTen19
left a comment
There was a problem hiding this comment.
오.. .task(id:) 라는 것도 있구나
좋네요 이제 onAppear, onChange 말고 다 태스크로 바꿔야겠다
바쁘실텐데 수고하셨습니다!
Contributor
|
오 task(id:)는 뷰 뿐만 아니라 id가 변경되어도 task가 취소되네요 대박. |
sangyup12
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 작업한 브랜치
refactor/#160✅ 작업한 내용
task 부분 수정했습니다..!
상엽슨과 전체적인 내용은 비슷한데 onAppear, onChange로 관리하던 애를
.task(id:)로 통합하였습니다..!
서버가 안돼서 잘 동작하는지는 따로 확인은 못해봤어요..
❗️PR Point
이제 빨리 캘린더를 향해..
📸 스크린샷
📟 관련 이슈