Skip to content

[Refactor] #160 - 멘토링 피드백 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yeonnies wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −24
Open

[Refactor] #160 - 멘토링 피드백 #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b51b4
[Refactor] #160 - Task 수정
Yeonnies Nov 8, 2025
b06e047
Merge branch 'develop' into refactor/#160
Yeonnies Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions CERTI-iOS/Presentation/Category/View/CategoryView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,8 @@ struct CategoryView: View {
CategoryLicenseCardList(viewModel: viewModel)
.padding(.horizontal, 20)
}
.onAppear {
Task {
await viewModel.getCategoryList()
}
}
.onChange(of: viewModel.selectedCategory) { _ in
Task{
await viewModel.getCategoryList()
}
.task(id: viewModel.selectedCategory) {
await viewModel.getCategoryList()
}
}
}
6 changes: 2 additions & 4 deletions CERTI-iOS/Presentation/CertificateDetail/View/CertificateDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,8 @@ struct CertificateDetailView: View {
.frame(maxWidth: .infinity, maxHeight: .infinity)
}
}
.onAppear {
Task {
await viewModel.fetchCertificateDetail(certificationId: certificationId)
}
.task {
await viewModel.fetchCertificateDetail(certificationId: certificationId)
}
}

Expand Down
15 changes: 4 additions & 11 deletions CERTI-iOS/Presentation/Recommend/View/RecommendView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,11 @@ struct RecommendView: View {
.presentationCornerRadius(40)
.presentationDragIndicator(.hidden)
}
.onAppear {
Task {
await viewModel.getRecommendCertificationList()
await viewModel.getJobList()
}
.task(id: viewModel.selectedJobField) {
async let recommendCertificationList: () = viewModel.getRecommendCertificationList()
async let jobList: () = viewModel.getJobList()
_ = await (recommendCertificationList, jobList)
}
.onChange(of: viewModel.selectedJobField, perform: { _ in
Task {
await viewModel.getRecommendCertificationList()
await viewModel.getJobList()
}
})
.overlay {
if viewModel.isShowLoading {
CertiLoadingView(name: AuthManager.shared.nickname)
Expand Down