adjust argument checking for > and >=
#993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please update the release notes. Thanks! |
If both arguments to `>` or `>=` are not real numbers, complain about the earlier argument. There's generally no guarantee about the order that arguments will be checked, but most checks are left-to-right, so it becomes expected by users. The checks for `>` and `>=` were backward only because they're implemented using `$<` and `$<=`. This small adjustment to error reporting should have minimal overall impact, since the adjustment is only only in the error case.
mflatt
force-pushed
the
gt-arg-error-order
branch
from
12ba6f9 to
7cb54a0
Compare
Contributor
Author
|
Release notes updated — with the same reservations as for #992 , and with the intent of merging the notes, assuming both PR get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both arguments to
>or>=are not real numbers, complain about the earlier argument. There's generally no guarantee about the order that arguments will be checked, but most checks are left-to-right, so it becomes expected by users. The checks for>and>=were backward only because they're implemented using$<and$<=. This small adjustment to error reporting should have minimal overall impact, since the adjustment is only only in the error case.