fix(types): fix Paper class method parameter typings in joint.d.ts#3195
Open
Geliogabalus wants to merge 2 commits intoclientIO:masterfrom
Open
fix(types): fix Paper class method parameter typings in joint.d.ts#3195Geliogabalus wants to merge 2 commits intoclientIO:masterfrom
Geliogabalus wants to merge 2 commits intoclientIO:masterfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kumilingus
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FORM_CONTROLS_TAG_NAMES→FORM_CONTROL_TAG_NAMES(typo, matches implementation)insertLayerViewsecond param frombefore?: Paper.LayerReftobeforeLayerView: LayerView | null(matches actual resolved type passed by callers)requestLayerViewRemoval— add missingopt?parametercheckMountedViews/checkUnmountedViews— widen first param fromViewportCallbacktoViewportCallback | CellVisibilityCallback | nullsortViews/sortViewsExact→sortLayerViews/sortLayerViewsExact(correct method names)drawBackgroundImage—imgnow acceptsnull,optis optionalupdateBackgroundColor—coloris optional (called with potentially-undefined values)createViewForModel— add missingcid?: stringparametercloneOptions— return typePaper.Options→void(no return statement in implementation)onGraphLayerCollectionSort— param typeGraphLayer[]→mvc.Collection<GraphLayer>with correct namelayerCollectiononGraphBatchStop(Paper class) — add missingdata?: { batchName: string }parameterrenderView— add missingopt?parameterTest plan
yarn test-tsto validate TypeScript definition correctness🤖 Generated with Claude Code