Skip to content

fix(types): fix Paper class method parameter typings in joint.d.ts #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Geliogabalus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(types): fix Paper class method parameter typings in joint.d.ts #3195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07d7af
type fixes
Geliogabalus Mar 2, 2026
356f085
up
Geliogabalus Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/joint-core/types/joint.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,7 @@ export namespace dia {
layers: SVGGElement;

GUARDED_TAG_NAMES: string[];
FORM_CONTROLS_TAG_NAMES: string[];
FORM_CONTROL_TAG_NAMES: string[];

matrix(): SVGMatrix;
matrix(ctm: SVGMatrix | Vectorizer.Matrix, data?: any): this;
Expand Down Expand Up @@ -2094,9 +2094,9 @@ export namespace dia {

removeLayerView(layerRef: Paper.LayerRef): void;

protected insertLayerView(layerView: LayerView, before?: Paper.LayerRef): void;
protected insertLayerView(layerView: LayerView, beforeLayerView?: LayerView): void;

protected requestLayerViewRemoval(layerRef: Paper.LayerRef): void;
protected requestLayerViewRemoval(layerRef: Paper.LayerRef, opt?: { [key: string]: any }): void;

protected createLayerView(options: Omit<LayerView.Options, 'paper'>): LayerView;

Expand Down Expand Up @@ -2185,9 +2185,9 @@ export namespace dia {

protected updateViewsBatch(opt?: Paper.UpdateViewsBatchOptions): Paper.RenderBatchStats;

protected checkMountedViews(viewport: Paper.ViewportCallback, opt?: Paper.UnmountOptions): number;
protected checkMountedViews(viewport: Paper.ViewportCallback | Paper.CellVisibilityCallback | null, opt?: Paper.UnmountOptions): number;

protected checkUnmountedViews(viewport: Paper.ViewportCallback, opt?: Paper.MountOptions): number;
protected checkUnmountedViews(viewport: Paper.ViewportCallback | Paper.CellVisibilityCallback | null, opt?: Paper.MountOptions): number;

protected prioritizeCellViewMount(cellOrId: Graph.CellRef): boolean;

Expand All @@ -2201,9 +2201,9 @@ export namespace dia {

protected isExactSorting(): boolean;

protected sortViews(): void;
protected sortLayerViews(): void;

protected sortViewsExact(): void;
protected sortLayerViewsExact(): void;

protected pointerdblclick(evt: dia.Event): void;

Expand Down Expand Up @@ -2235,15 +2235,15 @@ export namespace dia {

protected guard(evt: dia.Event, view: CellView): boolean;

protected drawBackgroundImage(img: HTMLImageElement, opt: { [key: string]: any }): void;
protected drawBackgroundImage(img: HTMLImageElement | null, opt?: { [key: string]: any }): void;

protected updateBackgroundColor(color: string): void;
protected updateBackgroundColor(color?: string): void;

protected updateBackgroundImage(opt: { position?: any, size?: any }): void;

protected createViewForModel(cell: Cell): CellView;
protected createViewForModel(cell: Cell, cid?: string): CellView;

protected cloneOptions(): Paper.Options;
protected cloneOptions(): void;

protected onCellAdded(cell: Cell, collection: mvc.Collection<Cell>, opt: dia.Graph.Options): void;

Expand All @@ -2258,13 +2258,13 @@ export namespace dia {

protected onGraphLayerCollectionReset(layer: mvc.Collection<GraphLayer>, opt: dia.Graph.Options): void;

protected onGraphLayerCollectionSort(layer: GraphLayer[]): void;
protected onGraphLayerCollectionSort(layerCollection: mvc.Collection<GraphLayer>): void;

protected onGraphReset(cells: mvc.Collection<Cell>, opt: dia.Graph.Options): void;

protected onGraphSort(): void;

protected onGraphBatchStop(): void;
protected onGraphBatchStop(data?: { batchName: string }): void;

protected onCellHighlight(cellView: CellView, magnetEl: SVGElement, opt?: { highlighter?: highlighters.HighlighterJSON }): void;

Expand All @@ -2276,7 +2276,7 @@ export namespace dia {

protected removeViews(): void;

protected renderView(cell: Cell): CellView;
protected renderView(cell: Cell, opt?: { [key: string]: any }): CellView;

protected resetViews(cells?: Cell[], opt?: { [key: string]: any }): void;

Expand Down
Loading