fix(catalogs): retain catalog secret err in status #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
reviewed
Nov 7, 2025
| if secretErr != nil { | ||
| msg = msg + "; " + secretErr.Error() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
If this is done inside the objectReadiness method, it would avoid the missing error checks from below.
24 tasks
Signed-off-by: abhijith-darshan <abhijith.ravindra@sap.com> (chore): retain catalog secret err in inventory status
abhijith-darshan
force-pushed
the
fix/retain_catalog_secret_err
branch
from
63a029f to
68d7b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catalog should retain secret error while applying
GitRepositoryresource.If there is an error checking the existence of
.spec.sources[*].secretNameSecret then it should be reflected in the inventory message forGitRepository.What type of PR is this? (check all applicable)
Added tests?
Added to documentation?
Checklist