Add War Thunder realtime source by codegefluester · Pull Request #14 · codegefluester/GamesDat

codegefluester · 2026-02-11T16:04:22Z

No description provided.

Copilot

Pull request overview

This pull request adds comprehensive War Thunder HTTP telemetry integration to GamesDat, including a generic HttpPollingSourceBase<T> for reusable HTTP polling functionality. The PR introduces telemetry capture from War Thunder's local HTTP API endpoints (/state and /indicators) with configurable polling rates, retry logic, and includes extensive testing support via Mockoon mock API configurations.

Changes:

Added generic HTTP polling infrastructure (HttpPollingSourceBase<T>, HttpPollingSourceOptions) for reusable HTTP-based telemetry sources
Implemented War Thunder-specific sources (StateSource, IndicatorsSource) with factory methods and data structures
Created comprehensive Mockoon mock API environment with example JSON files for testing without the game
Updated documentation with War Thunder integration guide, quick start, and mock API setup instructions

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`GamesDat/Telemetry/Sources/HttpPollingSourceBase.cs`	Abstract base class for HTTP polling telemetry sources with retry logic and JSON deserialization
`GamesDat/Telemetry/Sources/HttpPollingSourceOptions.cs`	Configuration options for HTTP polling sources including timeouts and retry settings
`GamesDat/Telemetry/Sources/WarThunder/WarThunderSources.cs`	Factory methods for creating War Thunder telemetry sources with sensible defaults
`GamesDat/Telemetry/Sources/WarThunder/StateSource.cs`	Concrete implementation for War Thunder's /state endpoint
`GamesDat/Telemetry/Sources/WarThunder/IndicatorsSource.cs`	Concrete implementation for War Thunder's /indicators endpoint
`GamesDat/Telemetry/Sources/WarThunder/StateData.cs`	Data structure for /state endpoint telemetry
`GamesDat/Telemetry/Sources/WarThunder/IndicatorsData.cs`	Data structure for /indicators endpoint telemetry
`GamesDat/Telemetry/Sources/WarThunder/WarThunderHttpClient.cs`	Shared HttpClient singleton to prevent socket exhaustion
`docs/WarThunder.md`	Comprehensive integration documentation with examples and API reference
`mockoon/war-thunder-environment.json`	Mockoon environment with dynamic faker.js templates for realistic mock data
`mockoon/README.md`	Detailed mock API documentation and testing scenarios
`mockoon/QUICKSTART.md`	Quick start guide for mock API setup
`mockoon/examples/*.json`	Static JSON examples for flying and ground states
`mockoon/.gitignore`	Git ignore patterns for Mockoon files
`README.md`	Updated game support table and added War Thunder examples
`GamesDat.Demo/Program.cs`	Added War Thunder capture example
`Examples/WarThunderExample.cs`	Comprehensive examples demonstrating various usage patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/WarThunder.md

GamesDat.Demo/Program.cs

GamesDat/Telemetry/Sources/HttpPollingSourceBase.cs

GamesDat/Telemetry/Sources/HttpPollingSourceOptions.cs

GamesDat.Demo/Program.cs

GamesDat/Telemetry/Sources/HttpPollingSourceBase.cs

codegefluester · 2026-02-11T16:14:09Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-02-11T16:14:18Z

@codegefluester I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

…ion (#15) * Initial plan * Address code review comments Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Remove redundant TaskCanceledException catch Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Clarify timeout cancellation comment Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GamesDat.Demo/Program.cs

Copilot · 2026-02-12T10:03:28Z

GamesDat/Telemetry/Sources/WarThunder/WarThunderSources.cs

+    public static StateSource CreateStateSource(string? baseUrl = null, int hz = 60)
+    {
+        var pollInterval = TimeSpan.FromMilliseconds(1000.0 / hz);
+        return new StateSource(baseUrl ?? DefaultBaseUrl, pollInterval);
+    }


hz is used as a divisor to compute pollInterval. If a caller passes hz <= 0, this will throw (divide-by-zero) or produce an invalid interval. Add validation (e.g., throw ArgumentOutOfRangeException) to ensure hz is positive.

Copilot · 2026-02-12T10:03:28Z

GamesDat/Telemetry/Sources/WarThunder/WarThunderSources.cs

+    public static IndicatorsSource CreateIndicatorsSource(string? baseUrl = null, int hz = 10)
+    {
+        var pollInterval = TimeSpan.FromMilliseconds(1000.0 / hz);
+        return new IndicatorsSource(baseUrl ?? DefaultBaseUrl, pollInterval);
+    }


Same hz validation issue as above: hz <= 0 will cause divide-by-zero/invalid interval. Validate hz and fail fast with a clear exception.

mockoon/war-thunder-environment.json

GamesDat/Telemetry/Sources/HttpPollingSourceBase.cs

codegefluester · 2026-02-12T10:06:37Z

@copilot open a new pull request to apply changes based on this feedback and this feedback

Copilot · 2026-02-12T10:06:46Z

@codegefluester I've opened a new pull request, #16, to work on those changes. Once the pull request is ready, I'll request review from you.

- Change StateData.Valid field type from int to bool (breaking change from PR #18) - Add parameter validation documentation for hz parameter (from PR #16) - Update troubleshooting section to reference boolean Valid field This update reflects changes from merged PRs #14, #16, #17, and #18. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

- Document breaking change: Valid field changed from int to bool - Add parameter validation section for hz parameter - Add breaking changes section at top of document - Update troubleshooting section to reference boolean type - Add notes about complete field listings in source files Addresses changes from PR #18, #16, #17, and #14. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

codegefluester added 2 commits February 11, 2026 16:49

Added War Thunder source for /state and /indicator endpoints

19cc310

Added mockoon resources

4851d06

Copilot AI review requested due to automatic review settings February 11, 2026 16:04

Copilot started reviewing on behalf of codegefluester February 11, 2026 16:05 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 11, 2026

Address code review feedback for War Thunder HTTP polling implementation #15

Merged

codegefluester requested a review from Copilot February 12, 2026 09:54

Copilot started reviewing on behalf of codegefluester February 12, 2026 09:55 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 12, 2026

Add hz parameter validation to WarThunder factory methods #16

Merged

Add hz parameter validation to WarThunder factory methods (#16)

dec7dc7

codegefluester merged commit 3d9615f into main Feb 12, 2026
1 check passed

codegefluester deleted the feat/add-war-thunder-realtime-source branch February 12, 2026 10:55

github-actions bot mentioned this pull request Feb 13, 2026

[docs] Update War Thunder documentation for v2.0.0 breaking changes #22

Merged

github-actions bot mentioned this pull request Feb 14, 2026

[agentics] No-Op Runs #23

Open

Conversation

codegefluester commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codegefluester commented Feb 11, 2026

Uh oh!

Copilot AI commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codegefluester commented Feb 12, 2026

Uh oh!

Copilot AI commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants