Add hz parameter validation to WarThunder factory methods#16
Merged
codegefluester merged 2 commits intofeat/add-war-thunder-realtime-sourcefrom Feb 12, 2026
Merged
Conversation
Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add War Thunder realtime source
Add hz parameter validation to WarThunder factory methods
Feb 12, 2026
codegefluester
approved these changes
Feb 12, 2026
codegefluester
pushed a commit
that referenced
this pull request
Feb 12, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
- Change StateData.Valid field type from int to bool (breaking change from PR #18) - Add parameter validation documentation for hz parameter (from PR #16) - Update troubleshooting section to reference boolean Valid field This update reflects changes from merged PRs #14, #16, #17, and #18. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
- Document breaking change: Valid field changed from int to bool - Add parameter validation section for hz parameter - Add breaking changes section at top of document - Update troubleshooting section to reference boolean type - Add notes about complete field listings in source files Addresses changes from PR #18, #16, #17, and #14. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
codegefluester
pushed a commit
that referenced
this pull request
Feb 13, 2026
- Document breaking change: Valid field changed from int to bool - Add parameter validation section for hz parameter - Add breaking changes section at top of document - Update troubleshooting section to reference boolean type - Add notes about complete field listings in source files Addresses changes from PR #18, #16, #17, and #14. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CreateStateSourceandCreateIndicatorsSourcefactory methods usedhzas a divisor without validation, causing divide-by-zero errors whenhz <= 0.Changes:
ArgumentOutOfRangeExceptionvalidation in both factory methods to reject non-positivehzvalues✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.