Skip to content

Add hz parameter validation to WarThunder factory methods#16

Merged
codegefluester merged 2 commits intofeat/add-war-thunder-realtime-sourcefrom
copilot/sub-pr-14
Feb 12, 2026
Merged

Add hz parameter validation to WarThunder factory methods#16
codegefluester merged 2 commits intofeat/add-war-thunder-realtime-sourcefrom
copilot/sub-pr-14

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

The CreateStateSource and CreateIndicatorsSource factory methods used hz as a divisor without validation, causing divide-by-zero errors when hz <= 0.

Changes:

  • Added ArgumentOutOfRangeException validation in both factory methods to reject non-positive hz values
  • Validation occurs before poll interval calculation to fail fast with clear error messages
public static StateSource CreateStateSource(string? baseUrl = null, int hz = 60)
{
    if (hz <= 0)
        throw new ArgumentOutOfRangeException(nameof(hz), hz, "Polling frequency must be greater than 0");
    
    var pollInterval = TimeSpan.FromMilliseconds(1000.0 / hz);
    return new StateSource(baseUrl ?? DefaultBaseUrl, pollInterval);
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Copilot AI changed the title [WIP] Add War Thunder realtime source Add hz parameter validation to WarThunder factory methods Feb 12, 2026
Copilot AI requested a review from codegefluester February 12, 2026 10:14
@codegefluester codegefluester marked this pull request as ready for review February 12, 2026 10:44
@codegefluester codegefluester merged commit dec7dc7 into feat/add-war-thunder-realtime-source Feb 12, 2026
@codegefluester codegefluester deleted the copilot/sub-pr-14 branch February 12, 2026 10:45
github-actions bot pushed a commit that referenced this pull request Feb 13, 2026
- Change StateData.Valid field type from int to bool (breaking change from PR #18)
- Add parameter validation documentation for hz parameter (from PR #16)
- Update troubleshooting section to reference boolean Valid field

This update reflects changes from merged PRs #14, #16, #17, and #18.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions bot pushed a commit that referenced this pull request Feb 13, 2026
- Document breaking change: Valid field changed from int to bool
- Add parameter validation section for hz parameter
- Add breaking changes section at top of document
- Update troubleshooting section to reference boolean type
- Add notes about complete field listings in source files

Addresses changes from PR #18, #16, #17, and #14.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
codegefluester pushed a commit that referenced this pull request Feb 13, 2026
- Document breaking change: Valid field changed from int to bool
- Add parameter validation section for hz parameter
- Add breaking changes section at top of document
- Update troubleshooting section to reference boolean type
- Add notes about complete field listings in source files

Addresses changes from PR #18, #16, #17, and #14.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions github-actions bot mentioned this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants