Skip to content

Add hz parameter validation to WarThunder factory methods #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codegefluester merged 2 commits into from
Feb 12, 2026
Merged

Add hz parameter validation to WarThunder factory methods #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c12689c
Initial plan
Copilot Feb 12, 2026
3c0b534
Add hz parameter validation to prevent divide-by-zero errors
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions GamesDat/Telemetry/Sources/WarThunder/WarThunderSources.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ public static class WarThunderSources
/// <returns>A configured StateSource instance.</returns>
public static StateSource CreateStateSource(string? baseUrl = null, int hz = 60)
{
if (hz <= 0)
throw new ArgumentOutOfRangeException(nameof(hz), hz, "Polling frequency must be greater than 0");

var pollInterval = TimeSpan.FromMilliseconds(1000.0 / hz);
return new StateSource(baseUrl ?? DefaultBaseUrl, pollInterval);
}
Expand All @@ -39,6 +42,9 @@ public static StateSource CreateStateSource(HttpPollingSourceOptions options)
/// <returns>A configured IndicatorsSource instance.</returns>
public static IndicatorsSource CreateIndicatorsSource(string? baseUrl = null, int hz = 10)
{
if (hz <= 0)
throw new ArgumentOutOfRangeException(nameof(hz), hz, "Polling frequency must be greater than 0");

var pollInterval = TimeSpan.FromMilliseconds(1000.0 / hz);
return new IndicatorsSource(baseUrl ?? DefaultBaseUrl, pollInterval);
}
Expand Down