Skip to content

Conversation

@RJWadley
Copy link

@RJWadley RJWadley commented Dec 3, 2025

goal: more closely align with stock ACC behavior on cars with unique buttons

some cars have +/- buttons that are separate. realistically for openpilot this just means VW, since most other affected cars makes use flexray, but it's not inherently a VW thing. KIA EV9 has independent buttons for example, but it treats them as SET so they're probably not affected here. VW's stock system allows adjustment of the set point while disabled. In most cars, the buttons are shared with RES/SET and this is inherently not possible.

tweaks:

  • handle cruise +/- when disabled
  • if we don't have an ACC setpoint, init one
  • tweak adjustment handling so it only ignores button presses that cross a state change
VW MQB KIA EV6
Screenshot 2025-12-02 at 10 05 32 PM Screenshot 2025-12-02 at 10 04 50 PM

Sample route showing adjustment while disabled:
a3d353f2254caee4/00000242--cb0f881531/0

@github-actions github-actions bot added the car vehicle-specific label Dec 3, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@RJWadley RJWadley marked this pull request as draft December 3, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car vehicle-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant