Skip to content

Drop curly braces in when statement#29

Open
dnmvisser wants to merge 2 commits intoctorgalson:masterfrom
dnmvisser:dv_fix_conditional_warning1
Open

Drop curly braces in when statement#29
dnmvisser wants to merge 2 commits intoctorgalson:masterfrom
dnmvisser:dv_fix_conditional_warning1

Conversation

@dnmvisser
Copy link

Avoids the following warning:

TASK [ansible-role-vim : Make sure it even makes sense to continue.] ******************************************************
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{
vim_version_string.stdout is version('8.0', '<') }}
skipping: [127.0.0.1]

this is with:

(venv) hax0r@macos-macbook-local macos-deploy$ ansible --version
ansible [core 2.15.9]
  config file = /Users/hax0r/macos-deploy/ansible.cfg
  configured module search path = ['/Users/hax0r/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/hax0r/macos-deploy/venv/lib/python3.9/site-packages/ansible
  ansible collection location = /Users/hax0r/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/hax0r/macos-deploy/venv/bin/ansible
  python version = 3.9.6 (default, Nov 10 2023, 13:38:27) [Clang 15.0.0 (clang-1500.1.0.2.5)] (/Users/hax0r/macos-deploy/venv/bin/python3)
  jinja version = 3.1.3
  libyaml = True

@ctorgalson
Copy link
Owner

This looks good to me, thanks 👍.

Could I ask you to quote the changed line to match the general style?

I'll add it to a release with all of the other requested changes on this project once I've given them a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants