Skip to content

Use new asset_validation_errors endpoint #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jjnesbitt wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use new asset_validation_errors endpoint #1823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions dandi/dandiapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,11 +1101,20 @@ def get_version(self, version_id: str) -> VersionInfo:
`Version`.
"""
try:
return VersionInfo.model_validate(
self.client.get(
f"/dandisets/{self.identifier}/versions/{version_id}/info/"
)
info_resp = self.client.get(
f"/dandisets/{self.identifier}/versions/{version_id}/info/"
)

# Handle validation error changes https://github.com/dandi/dandi-archive/pull/2719
if "asset_validation_errors" not in info_resp:
info_resp["asset_validation_errors"] = self.client.get(
f"/dandisets/{self.identifier}/versions/{version_id}/asset_validation_errors/"
)
info_resp["version_validation_errors"] = info_resp.pop(
"validation_errors"
)

return VersionInfo.model_validate(info_resp)
except HTTP404Error:
raise NotFoundError(
f"No such version: {version_id!r} of Dandiset {self.identifier}"
Expand Down
Loading