fix: DH-21413: fail if there's non-whitespace material after a cell's closing quote #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
force-pushed
the
kosak_fail-on-excess-material
branch
3 times, most recently
from
113b330 to
aba180d
Compare
lbooker42
approved these changes
Jan 15, 2026
kosak
force-pushed
the
kosak_fail-on-excess-material
branch
from
aba180d to
a405d48
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current code correctly rejects the input
"hello"there(i.e. trailing material after the closing quote)
But if fails to reject this input
"hello"there"The second closing quote confuses the existing code into thinking this input is acceptable.
It is not
The correct way to have an embedded quote is to double it, as in
"hello""there"Or, when #309 is merged, escape it as in
"hello\"there"(provided you have configured an escape character)