Refactor: Clean up code after optparse-applicative migration #94
+290
−481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit performs code cleanup following the migration to optparse-applicative in PR #90: **Module Changes:** - Rename NewCommandLineParser.hs to CommandLineParser.hs - Remove old GetOpt-based CommandLineParser module **Main.hs Cleanup:** - Update import from NewCommandLineParser to CommandLineParser - Remove obsolete comments ("Old...", "Refactored...", "TODO...") - Remove commented-out imports (System.Console.GetOpt, System.Environment) - Improve code formatting and consistency - Remove unnecessary blank lines - Align guard clauses in remoteUrlToRemote All changes maintain backward compatibility while improving code readability and maintainability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diskshima
added a commit
that referenced
this pull request
Oct 11, 2025
… → CommandLineParser) (#93) * Refactor: Rename NewCommandLineParser to CommandLineParser in cabal config Update the gwcli.cabal file to reflect the module rename from NewCommandLineParser to CommandLineParser, removing the old module from the exposed-modules list. Also add cabal.project.freeze to lock dependency versions for reproducible builds with GHC 9.12.1 and Cabal 3.14. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Refactor: Clean up code after optparse-applicative migration (#94) * Refactor: Clean up code after optparse-applicative migration This commit performs code cleanup following the migration to optparse-applicative in PR #90: **Module Changes:** - Rename NewCommandLineParser.hs to CommandLineParser.hs - Remove old GetOpt-based CommandLineParser module **Main.hs Cleanup:** - Update import from NewCommandLineParser to CommandLineParser - Remove obsolete comments ("Old...", "Refactored...", "TODO...") - Remove commented-out imports (System.Console.GetOpt, System.Environment) - Improve code formatting and consistency - Remove unnecessary blank lines - Align guard clauses in remoteUrlToRemote All changes maintain backward compatibility while improving code readability and maintainability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Bump version to 0.9.8.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> * Update changelog for version 0.9.8.0 Add changelog entries documenting the refactoring work: - Module renaming (NewCommandLineParser to CommandLineParser) - Removal of old GetOpt-based parser - Code cleanup and formatting improvements - Maintainability improvements after optparse-applicative migration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR performs code cleanup following the migration to optparse-applicative in PR #90. It renames modules, removes obsolete code, and improves formatting.
Note: This PR is stacked on top of #93 and should be merged after it.
Changes
Module Refactoring:
src/NewCommandLineParser.hs→src/CommandLineParser.hsCommandLineParsermoduleMain.hsCode Cleanup in Main.hs:
System.Console.GetOpt,System.Environment)remoteUrlToRemoteImpact
Testing
cabal buildRelated
Part 2 of cleanup for #90 (code cleanup)
Depends on: #93
🤖 Generated with Claude Code