Add custom exception handling for more dotnetup edge cases#53163
Draft
nagilson wants to merge 2 commits intodotnet:release/dnupfrom
Draft
Add custom exception handling for more dotnetup edge cases#53163nagilson wants to merge 2 commits intodotnet:release/dnupfrom
dotnetup edge cases#53163nagilson wants to merge 2 commits intodotnet:release/dnupfrom
Conversation
This PR improves the recently added telemetry in several ways: 1. A feedback comment which was valuable was that we used to catch and rethrow exceptions at command base, but we removed that. It turns out this actually was an important pattern because the error information does not get propagated at the root level and it is very slow in Kusto to filter out the command based errors in queries without this pattern. 2. I thought of more error categories that could be handled distinctinly: A. Corrupt manifests - The manifest could've been corrupted by us but the user also may have tried to manually edit it. Separate those error categories. B. --install-dir : the user may try to install into a file instead of a directory. Consider this a user error and not a product error. 3. The workbook now counts the amount of distinct errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the recently added telemetry in several ways:
A feedback comment which was valuable was that we used to catch and rethrow exceptions at command base, but we removed that. It turns out this actually was an important pattern because the error information does not get propagated at the root level and it is very slow in Kusto to filter out the command based errors in queries without this pattern.
I thought of more error categories that could be handled distinctinly:
A. Corrupt manifests - The manifest could've been corrupted by us but the user also may have tried to manually edit it. Separate those error categories.
B. --install-dir : the user may try to install into a file instead of a directory. Consider this a user error and not a product error.
The workbook now counts the amount of distinct errors.