Added checking is property not empty string#516
Open
idziakjakub wants to merge 1 commit intodweeves:masterfrom
Open
Added checking is property not empty string#516idziakjakub wants to merge 1 commit intodweeves:masterfrom
idziakjakub wants to merge 1 commit intodweeves:masterfrom
Conversation
Collaborator
|
This patch also fixed division by zero issue. |
Collaborator
|
@dweeves any feedback on this? |
Owner
|
hi, i was hesitating to merge because of possible impact for purposedly empty values in config files for plugins (which inherit from properties). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes null return when property is empty string.
When property was empty default value has never been returned.