Skip to content

Adopt sanitizers from @score_cpp_policies#182

Draft
RSingh1511 wants to merge 3 commits intoeclipse-score:mainfrom
RSingh1511:rs/swp-249901
Draft

Adopt sanitizers from @score_cpp_policies#182
RSingh1511 wants to merge 3 commits intoeclipse-score:mainfrom
RSingh1511:rs/swp-249901

Conversation

@RSingh1511
Copy link

@RSingh1511 RSingh1511 commented Mar 12, 2026

No description provided.

rmaddikery
rmaddikery reviewed Mar 12, 2026
View reviewed changes
rmaddikery
rmaddikery reviewed Mar 12, 2026
View reviewed changes
quality/integration_testing/sanitizer_support/BUILD Outdated
cc_test(
name = "tsan_fail_data_race",
srcs = ["tsan_fail_data_race.cpp"],
# Re-package suppressions from @score_cpp_policies for integration testing
Copy link
Contributor

@rmaddikery rmaddikery Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why re-package here?
OK in case the repo has its own suppressions..?

Copy link
Author

@RSingh1511 RSingh1511 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-packaging is needed for integration tests running in Docker so the suppression files from @score_cpp_policies are available at /sanitizers/suppressions/

Copy link
Contributor

@LittleHuba LittleHuba Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a way to specify our suppressions in this repository. There might be some that can be centralized (stdlib ones for example) but we will likely have some here that are exlusive to this repository.

Copy link
Author

@RSingh1511 RSingh1511 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added repo-specific suppression files that merge with centralized ones from @score_cpp_policies in integration tests

@FScholPer FScholPer mentioned this pull request Mar 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LittleHuba LittleHuba Awaiting requested review from LittleHuba LittleHuba is a code owner

@rmaddikery rmaddikery Awaiting requested review from rmaddikery

@castler castler Awaiting requested review from castler castler will be requested when the pull request is marked ready for review castler is a code owner

@hoe-jo hoe-jo Awaiting requested review from hoe-jo hoe-jo will be requested when the pull request is marked ready for review hoe-jo is a code owner

@crimson11 crimson11 Awaiting requested review from crimson11 crimson11 will be requested when the pull request is marked ready for review crimson11 is a code owner

@bemerybmw bemerybmw Awaiting requested review from bemerybmw bemerybmw will be requested when the pull request is marked ready for review bemerybmw is a code owner

@limdor limdor Awaiting requested review from limdor limdor will be requested when the pull request is marked ready for review limdor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RSingh1511 @LittleHuba @rmaddikery