Femcal update #855
Open
Femcal update #855
+553
−477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
7 tasks
Author
|
Auto check uses craterlake for overlap checks. Do I change craterlake (and all other craterlake_*)? |
Member
Yes, please update all configurations to use your new xml. |
veprbl
reviewed
May 2, 2025
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
I have some preliminary comments.
This comment was marked as resolved.
This comment was marked as resolved.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
veprbl
reviewed
Nov 6, 2025
for more information, see https://pre-commit.ci
…om compact xml file
for more information, see https://pre-commit.ci
Author
|
I think the overlap is now gone. 2 pending checks after 1/2 day. Anything else? |
Author
|
I have no idea what those 2 failed check are : nvidia-smi & sim:zdc_lyso |
for more information, see https://pre-commit.ci
veprbl
reviewed
Nov 12, 2025
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
Have a question about segmentation. I think, we should make it into a consistent bit field for both implementations.
veprbl
previously approved these changes
Nov 14, 2025
veprbl
previously approved these changes
Nov 14, 2025
Author
|
Confimed that removing fake segmantation runs ok. Not sure what I saw 1/2 year ago. I tested it repeatedly. Anyway thanks for all those changes. |
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Nov 14, 2025
### Briefly, what does this PR introduce? Following Forward EM calorimeter geometry update: eic/epic#855 this provides switch between Homogeneous and ScFi geometry implementations based on xml file loaded - For Homogenous, we keep energy smearing as is. SF=1.0 - For ScFi, hits from fibers are summed to a tower and no enrgy smearing applied. SF=0.03. - Remove active insert which won't be built Added an option to put SiPM saturation to CalorimeterHitDigi - Specify 2 new parameters : totalPixel and nPhotonPerGeV - default for totalPixel is 0, which case no attenuation is applied - For FEMC for both geometry models, SiPM saturation is ON by default - Use "-PFEMC:SiPMSaturation=OFF" to turn it off See following links for some more details: https://www.star.bnl.gov/~akio/epic/geometry/index.html https://www.star.bnl.gov/~akio/epic/reco/index.html https://www.star.bnl.gov/~akio/epic/hadron/index.html ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? I don't think so, unless one provides wrong config xml file (until sum check in place) ### Does this PR change default behavior? It does apply SiPM attenuation by default for FEMC (but not other calorimeters). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
New Forward EM calorimeter geometry with current design. There are 2 models, homogeneous and Wpowder+ScFi.
Also removes active insert, which won't be built.
See following links for some more details:
https://www.star.bnl.gov/~akio/epic/geometry/index.html
https://www.star.bnl.gov/~akio/epic/reco/index.html
https://www.star.bnl.gov/~akio/epic/hadron/index.html
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
See also PR for EICrecon for digitization change
eic/EICrecon#1848
Does this PR change default behavior?
Not until default configuration files start to use new geometry