-
Notifications
You must be signed in to change notification settings - Fork 53
Femcal update #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akioogawa
wants to merge
71
commits into
main
Choose a base branch
from
fEcal_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Femcal update #855
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
463e91c
initial version of fEcal update with current design
0c3a786
include beam pipe protector instead of insert.h
0259f97
z location update, new yml files, and hit update
3ae5445
Adding a version with actual 760 ScFi
ca908f4
adding fake CartesianGridXY for ScFi hits for speed while looking for
akioogawa 2ab0ad8
hit and detector name back to original. Small bug fix in map
akioogawa f133db2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f908817
Merge branch 'main' into fEcal_update
akioogawa d2f94ee
spdx
akioogawa 8326c34
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 15db2d2
changing craterlake.yml for auto overlap check
akioogawa be6af38
Delete configurations/craterlake_newfEcal.yml
akioogawa 76a7834
just renaming
akioogawa 8026edc
name change
akioogawa cea4eb1
rename preparing for merging
akioogawa 6d07ce2
Merging 2 geo.cpp
akioogawa 71a470a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 18dcd8f
switching to new forward ecal geometry in all confiugration
akioogawa 0b7b36f
Fix typo which caused a crash
akioogawa 5d53535
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 89b3f8e
Merge branch 'main' into fEcal_update
akioogawa 44985a4
fix overlap with mother volume for bpp
akioogawa 2ee4f7e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6d18af3
fix material for homogeneous and name change for some volumes
akioogawa e2210eb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c70ed92
Merge branch 'main' into fEcal_update
akioogawa 4469a12
Merge branch 'main' into fEcal_update
veprbl cb2d525
Merge branch 'main' into fEcal_update
veprbl 4001c76
Merge branch 'main' into fEcal_update
akioogawa 0d99556
Merge remote-tracking branch 'origin/main' into fEcal_update
veprbl 4cdef89
rename internal compact name: forward_ScFi and forward_averaged_homog…
veprbl 0e2910e
StainlessSteel is not a material anymore, use StainlessSteelSAE304 as…
veprbl 73e7fb0
remove old compact/ecal/forward_homogeneous.xml
veprbl d992ae6
remove src/EndcapCalorimeterWithInsertCutout_geo.cpp
veprbl 01f4899
update outdated configurations
veprbl 47bdc84
Merge remote-tracking branch 'origin/main' into fEcal_update
veprbl 2e791f6
fix build
veprbl fc3c36e
fix ci
veprbl c180c17
fix spelling
veprbl 153f0d7
configurations: lfhcal_with_space_for_insert was deprecated on main
veprbl b3433a0
Merge branch 'main' into fEcal_update
akioogawa c7c46ce
Remove "dead code"
akioogawa f6d6fe7
Merge branch 'main' into fEcal_update
veprbl 8941e01
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 21de090
fixup after merging main
veprbl 1460275
fiberx -> fiber_x (consistency with the other scfi implementations)
veprbl c907a67
Moving constants and logic to xml file
akioogawa f73fec7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b7772d5
put back rmin
akioogawa 4233c4f
no more ecal insert, so new HcalEndcapPInsert_hole_xxx constants
akioogawa b665bfe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2b33620
No more forward ecal insert
akioogawa cc55192
Merge branch 'main' into fEcal_update
akioogawa 7a698bf
Fix a typo in xml fomula in definitions.xml
akioogawa 5c42be4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 31664f1
Merge branch 'main' into fEcal_update
akioogawa 262799a
Moving some more constants out of forwardEcalMap.h but take values fr…
akioogawa a3102cf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] abf4250
Merge branch 'main' into fEcal_update
akioogawa 4c9f4e9
remove configurations/becal.yml (use imaging_only.yml)
veprbl e3849f7
remove commented code in xmls
veprbl 6079c20
forwardEcal_geo.cpp: remove old hardcoding
veprbl 69e5da0
src/forwardEcalMap.h: remove some unused constants
veprbl f6ff9ef
Merge remote-tracking branch 'origin/main' into fEcal_update
veprbl 6d14183
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fa442d5
Use NoSegmentation
veprbl 272589b
tower_x,tower_y -> x,y
veprbl 8dd888b
naming
veprbl 0783137
naming2
veprbl f0b4f5e
Merge branch 'main' into fEcal_update
veprbl a0ac51d
rename3
veprbl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| <!-- SPDX-License-Identifier: LGPL-3.0-or-later --> | ||
| <!-- Copyright (C) 2025 Akio Ogawa, Whitney Armstrong, Chao Peng, Sylvester Joosten, Zhongling Ji, Ryan Milton --> | ||
|
|
||
| <lccdd> | ||
|
|
||
| <info name="forwardEcalScFi.xml" | ||
| title="forward ECal 2025 design" | ||
| author="@akioogawa" | ||
| url="https://github.com/akioogawa" | ||
| status="development" | ||
| version="1.0"> | ||
| <comment/></info> | ||
|
|
||
| <define> | ||
| <documentation> | ||
| - Forward Ecal Homogeneous(1) or ScFi(2) Model | ||
| </documentation> | ||
| <constant name="EcalEndcapP_Homogeneous_ScFi" value="2"/> | ||
| </define> | ||
|
|
||
| <limits> | ||
| </limits> | ||
|
|
||
| <regions> | ||
| </regions> | ||
|
|
||
| <display> | ||
| </display> | ||
|
|
||
| <detectors> | ||
|
|
||
| <documentation> | ||
| ### Forward (Positive Z) Endcap ScFi Electromagnetic Calorimeter | ||
| Implementation of 2025 design | ||
| Insert shape is cut out from middle of detector | ||
| </documentation> | ||
| <detector id="EcalEndcapP_ID" | ||
| name="EcalEndcapP" | ||
| type="epic_ForwardEcal" | ||
| readout="EcalEndcapPHits"> | ||
| <position x="0" y="0" z="EcalEndcapP_zmin"/> | ||
| <dimensions rmin="EcalEndcapP_rmin" rmax="EcalEndcapP_rmax" z="EcalEndcapP_length"/> | ||
| <slice name="Cover" material="Aluminum" thickness="EcalEndcapP_CoverThickness" vis="AnlGray"/> | ||
| <slice name="Air" material="Air" thickness="EcalEndcapP_AirThickness" vis="AnlLight_Gray"/> | ||
| <slice name="PCB" material="Fr4" thickness="EcalEndcapP_PCBThickness" vis="AnlGreen"/> | ||
| <slice name="LG" material="Plexiglass" thickness="EcalEndcapP_LightGuideThickness" vis="AnlBlue"/> | ||
| <slice name="WScFi" material="AvgTungstenScFi" thickness="EcalEndcapP_ScintillatorThickness" vis="AnlOrange" sensitive="true"/> | ||
| <slice name="MountingPlate" material="StainlessSteelSAE304" thickness="EcalEndcapP_MountingPlateThickness" vis="AnlGray"/> | ||
| </detector> | ||
| </detectors> | ||
|
|
||
| <!-- Definition of the readout segmentation/definition --> | ||
| <readouts> | ||
| <readout name="EcalEndcapPHits"> | ||
| <segmentation type="NoSegmentation"/> | ||
| <id>system:8,northsouth:1,blockrow:6,blockcol:5,x:2,y:2,fiber_x:5,fiber_y:5</id> | ||
| </readout> | ||
| </readouts> | ||
|
|
||
| <plugins> | ||
| </plugins> | ||
|
|
||
| </lccdd> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
|
|
||
| <!-- SPDX-License-Identifier: LGPL-3.0-or-later --> | ||
| <!-- Copyright (C) 2025 Akio Ogawa, Whitney Armstrong, Chao Peng, Sylvester Joosten, Zhongling Ji, Ryan Milton --> | ||
|
|
||
| <lccdd> | ||
|
|
||
| <info name="forwardEcal.xml" | ||
| title="forward ECal 2025 design" | ||
| author="@akioogawa" | ||
| url="https://github.com/akioogawa" | ||
| status="development" | ||
| version="1.0"> | ||
| <comment/></info> | ||
|
|
||
| <define> | ||
| <documentation> | ||
| - Forward Ecal Homogeneous(1) or ScFi(2) Model | ||
| </documentation> | ||
| <constant name="EcalEndcapP_Homogeneous_ScFi" value="1"/> | ||
| </define> | ||
|
|
||
| <limits> | ||
| </limits> | ||
|
|
||
| <regions> | ||
| </regions> | ||
|
|
||
| <display> | ||
| </display> | ||
|
|
||
| <detectors> | ||
|
|
||
| <documentation> | ||
| ### Forward (Positive Z) Endcap ScFi Electromagnetic Calorimeter | ||
| Implementation of 2025 design | ||
| Insert shape is cut out from middle of detector | ||
| </documentation> | ||
| <detector id="EcalEndcapP_ID" | ||
| name="EcalEndcapP" | ||
| type="epic_ForwardEcal" | ||
| readout="EcalEndcapPHits"> | ||
| <position x="0" y="0" z="EcalEndcapP_zmin"/> | ||
| <dimensions rmin="EcalEndcapP_rmin" rmax="EcalEndcapP_rmax" z="EcalEndcapP_length"/> | ||
| <slice name="Cover" material="Aluminum" thickness="EcalEndcapP_CoverThickness" vis="AnlGray"/> | ||
| <slice name="Air" material="Air" thickness="EcalEndcapP_AirThickness" vis="AnlLight_Gray"/> | ||
| <slice name="PCB" material="Fr4" thickness="EcalEndcapP_PCBThickness" vis="AnlGreen"/> | ||
| <slice name="LG" material="Plexiglass" thickness="EcalEndcapP_LightGuideThickness" vis="AnlBlue"/> | ||
| <slice name="WScFi" material="AvgTungstenScFi" thickness="EcalEndcapP_ScintillatorThickness" vis="AnlOrange" sensitive="true"/> | ||
| <slice name="MountingPlate" material="StainlessSteelSAE304" thickness="EcalEndcapP_MountingPlateThickness" vis="AnlGray"/> | ||
| </detector> | ||
| </detectors> | ||
|
|
||
| <!-- Definition of the readout segmentation/definition --> | ||
| <readouts> | ||
| <readout name="EcalEndcapPHits"> | ||
| <segmentation type="CartesianGridXY" grid_size_x="25*mm" grid_size_y="25*mm" offset_x="-37.5*mm" offset_y="-37.5*mm"/> | ||
| <id>system:8,northsouth:1,blockrow:6,blockcol:5,x:2,y:2</id> | ||
| </readout> | ||
| </readouts> | ||
|
|
||
| <plugins> | ||
| </plugins> | ||
|
|
||
| </lccdd> |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.