Improve TestKubernetesJournaldInput #11256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors
Contributor
|
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
|
swiatekm
approved these changes
Nov 19, 2025
Collaborator
⏳ Build in-progress, with failures
Failed CI Stepscc @belimawr |
Contributor
Author
|
The failing tests seem unrelated: #11253 |
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
Collaborator
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Member
|
We've seen this on 9.2 also, so I believe we should backport to at 9.2. @belimawr thoughts about other backports? |
belimawr
added
the
backport-active-9
Contributor
|
@Mergifyio backport 9.1 9.2 |
Contributor
✅ Backports have been created
|
Contributor
Author
Yeah, that makes sense. Any active branch with this tests. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors (cherry picked from commit 3062264)
8 tasks
Contributor
Author
|
I'll check all active branches with this test and create the backports. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors (cherry picked from commit 3062264)
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors (cherry picked from commit 3062264) # Conflicts: # testing/integration/k8s/testdata/journald-otel.yml
8 tasks
belimawr
added a commit
that referenced
this pull request
Nov 20, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors (cherry picked from commit 3062264) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr
added a commit
that referenced
this pull request
Nov 20, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors (cherry picked from commit 3062264) # Conflicts: # testing/integration/k8s/testdata/journald-otel.yml Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
pierrehilbert
pushed a commit
that referenced
this pull request
Nov 21, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors (cherry picked from commit 3062264) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
hayotbisonai
pushed a commit
to hayotbisonai/elastic-agent
that referenced
this pull request
Nov 23, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors
swiatekm
pushed a commit
that referenced
this pull request
Nov 24, 2025
- Log as ndjson so logs can easily be parsed/ingested into Elasticsearch - Set the log level to debug so we can see the events - If the test fails, log the index and search condition used - Improve `FindESDocs` to not log expected failures/errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FindESDocsto not log expected failures/errorsWhy is it important?
It makes TestKubernetesJournaldInput easier to debug and likely fixes #11220
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E test## Disruptive User ImpactHow to test this PR locally
Related issues
TestKubernetesJournaldInputOtel–Condition never satisfied#11220Questions to ask yourself