Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 20, 2025

What does this PR do?

  • Log as ndjson so logs can easily be parsed/ingested into Elasticsearch
  • Set the log level to debug so we can see the events
  • If the test fails, log the index and search condition used
  • Improve FindESDocs to not log expected failures/errors

Why is it important?

It makes TestKubernetesJournaldInput easier to debug and likely fixes #11220

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

## Disruptive User Impact

How to test this PR locally

DEV=true SNAPSHOT=true EXTERNAL=true DOCKER_VARIANTS="elastic-otel-collector" PACKAGES="docker" PLATFORMS=linux/amd64 mage -v package
SNAPSHOT=true INSTANCE_PROVISIONER=kind mage -v integration:testKubernetesSingle TestKubernetesJournaldInputOtel

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #11256 done by [Mergify](https://mergify.com).

- Log as ndjson so logs can easily be parsed/ingested into
Elasticsearch
- Set the log level to debug so we can see the events
- If the test fails, log the index and search condition used
- Improve `FindESDocs` to not log expected failures/errors

(cherry picked from commit 3062264)
@mergify mergify bot added the backport label Nov 20, 2025
@mergify mergify bot requested a review from a team as a code owner November 20, 2025 20:29
@mergify mergify bot requested review from swiatekm and ycombinator and removed request for a team November 20, 2025 20:29
@mergify mergify bot added the backport label Nov 20, 2025
@mergify mergify bot mentioned this pull request Nov 20, 2025
8 tasks
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Nov 20, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@belimawr
Copy link
Contributor

The CI failure is definitely unrelated, I might be the same issue as #10917

@pierrehilbert pierrehilbert merged commit f17ce0d into 9.2 Nov 21, 2025
21 of 24 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/9.2/pr-11256 branch November 21, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants