fixed bug with dimple height being incorrect#11
Open
MaikoHermans wants to merge 2 commits intoeoghain:masterfrom
Open
fixed bug with dimple height being incorrect#11MaikoHermans wants to merge 2 commits intoeoghain:masterfrom
MaikoHermans wants to merge 2 commits intoeoghain:masterfrom
Conversation
|
|
||
| if(height <= 10){ | ||
| height = additionalHeight * 2; | ||
| } |
Owner
There was a problem hiding this comment.
You should match existing file indenting and code style (i.e. tab indentation, curly braces on new lines aligned with start of block, etc.). This is just good practice when working in someone elses code base.
Author
There was a problem hiding this comment.
weird that it did that. When I edited it it was the same code style. Thanks for telling me tho next time I'll be sure to take a better look at it. Also after some more testing with it it seems that this bug occurred because of the way I set up my layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the
interItemSpacingYis set to 0 the dimple was being drawn to high because of the following lineviewRect.origin.y -= additionalHeight * 2;by checking if the height is smaller or equal to 10 the accurate height can be given to the dimple.
also when the
interItemSpacingYwas set to a - value the dimple wouldn't draw like supposed to. this is also fixed with the added code